Re: [PATCH] PR gdb/30219: Clear sync_quit_force_run in quit_force

[Kevin Buettner <kevinb@redhat.com>]

On Thu, 23 Mar 2023 11:26:56 -0400
Simon Marchi <simon.marchi@polymtl.ca> wrote:

> > diff --git a/gdb/annotate.c b/gdb/annotate.c
> > index 60fe6ccd5c2..36efce1af7c 100644
> > --- a/gdb/annotate.c
> > +++ b/gdb/annotate.c
> > @@ -282,6 +282,13 @@ annotate_quit (void)
> >      printf_unfiltered (("\n\032\032quit\n"));
> >  }
> >  
> > +void
> > +annotate_forced_quit (void)
> > +{
> > +  if (annotation_level > 1)
> > +    printf_unfiltered (("\n\032\032forced-quit\n"));  
> 
> Hmm, this in a new annotation?  In theory, this would need to be
> documented, to have a NEWS entry, etc.  And then frontends using
> annotations would need to be updated to use that.  We don't really want
> that, if possible, given annotations are obsolete.
> 
> Would it work to display the "quit" annotation (the one printed by
> annotate_quit)?  The doc [1] says, for that annotation:
> 
>   This annotation occurs right before GDB responds to an interrupt. 
> 
> and:
> 
>   Quit and error annotations indicate that any annotations which GDB was
>   in the middle of may end abruptly. For example, if a
>   value-history-begin annotation is followed by a error, one cannot
>   expect to receive the matching value-history-end.
> 
> I think it also works in the forced quit case.  The execution of
> whatever thing was going on is interrupted, just like in the regular
> quit case, it just happens that GDB also happens to exit after that.
> 
> [1] https://sourceware.org/gdb/onlinedocs/annotate.html#Errors

I agree.  I've prepared a v2 patch which I'll send shortly.

Kevin