From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed 1/2] [gdb/testsuite] Remove superfluous pid in temp files
Date: Mon, 27 Mar 2023 11:36:30 +0200 [thread overview]
Message-ID: <20230327093631.15655-1-tdevries@suse.de> (raw)
While trying to use gdb_can_simple_compile with a d program, I ran into:
...
/data/vries/gdb/f37/build/gdb/testsuite/temp/105856/can_compile_d-105856.d: \
error: module 'can_compile_d-105856' has non-identifier characters in \
filename, use module declaration instead
...
The d compiler has a problem with the filename can_compile_d-105856.d, which
contains the pid. The pid is added by gdb_simple_compile:
...
set obj [standard_temp_file $name-[pid].$postfix]
...
but it's unnecessary because standard_temp_file already uses the pid.
Fix this by removing "[pid]" in all calls to standard_temp_file.
Tested on x86_64-linux.
---
gdb/testsuite/lib/dwarf.exp | 2 +-
gdb/testsuite/lib/gdb.exp | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/gdb/testsuite/lib/dwarf.exp b/gdb/testsuite/lib/dwarf.exp
index 8b0cf77412d..434495df24a 100644
--- a/gdb/testsuite/lib/dwarf.exp
+++ b/gdb/testsuite/lib/dwarf.exp
@@ -294,7 +294,7 @@ proc shared_gdb_start_use { src options } {
}
if { $do_start } {
- set exe [standard_temp_file func_addr[pid].x]
+ set exe [standard_temp_file func_addr.x]
gdb_compile $src $exe executable $options
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 3cfe22b32cd..f8046ffe84d 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -4579,8 +4579,8 @@ gdb_caching_proc universal_compile_options {} {
set me "universal_compile_options"
set options {}
- set src [standard_temp_file ccopts[pid].c]
- set obj [standard_temp_file ccopts[pid].o]
+ set src [standard_temp_file ccopts.c]
+ set obj [standard_temp_file ccopts.o]
gdb_produce_source $src {
int foo(void) { return 0; }
@@ -4635,8 +4635,8 @@ proc gdb_simple_compile {name code {type object} {compile_flags {}} {object obj}
break
}
}
- set src [standard_temp_file $name-[pid].$ext]
- set obj [standard_temp_file $name-[pid].$postfix]
+ set src [standard_temp_file $name.$ext]
+ set obj [standard_temp_file $name.$postfix]
set compile_flags [concat $compile_flags {debug nowarnings quiet}]
gdb_produce_source $src $code
@@ -7011,8 +7011,8 @@ gdb_caching_proc allow_float_test {} {
# Set up, compile, and execute a test program having VFP
# operations.
- set src [standard_temp_file arm_vfp[pid].c]
- set exe [standard_temp_file arm_vfp[pid].x]
+ set src [standard_temp_file arm_vfp.c]
+ set exe [standard_temp_file arm_vfp.x]
gdb_produce_source $src {
int main() {
base-commit: 324998b47364528f407666512015370c12ab83a1
--
2.35.3
next reply other threads:[~2023-03-27 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 9:36 Tom de Vries [this message]
2023-03-27 9:36 ` [pushed 2/2] [gdb/testsuite] Handle missing gdc in gdb.dlang/dlang-start.exp Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230327093631.15655-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).