From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id BFF0F3858CDA for ; Mon, 27 Mar 2023 09:36:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BFF0F3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DC53F1FD6B for ; Mon, 27 Mar 2023 09:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679909791; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUJHy8Besun1mOA596RemUKLXxUEpOIqaxyq/Ooc09s=; b=tXwYobXMJZI2EIbZCCwLRgWq5kJ213KySEbHNBRc8j/4ERQM/DeBLH/vzGpYiHLuoWj5Mt UhKF/pyOI2t0xSyWgfNlzknh7130i88NgLo+W/KZgPOh3EkqEAeJ35aysklK2aqts51v9p l41QR7Gy9LggYoSDMfkdY9m60dWVG3o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679909791; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUJHy8Besun1mOA596RemUKLXxUEpOIqaxyq/Ooc09s=; b=S2w6tmfOzVKyj/649mhLy9Xpl+HsU8m7zh/Qj+j0xtzn0b0cfg0N43NCph4bmYknLizjM2 drMDg1/dhFkSjFCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C9A72138ED for ; Mon, 27 Mar 2023 09:36:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uPYbMJ9jIWStaQAAMHmgww (envelope-from ) for ; Mon, 27 Mar 2023 09:36:31 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed 2/2] [gdb/testsuite] Handle missing gdc in gdb.dlang/dlang-start.exp Date: Mon, 27 Mar 2023 11:36:31 +0200 Message-Id: <20230327093631.15655-2-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230327093631.15655-1-tdevries@suse.de> References: <20230327093631.15655-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On openSUSE Leap 15.4, I get: ... Running gdb.dlang/dlang-start.exp ... gdb compile failed, default_target_compile: Can't find gdc. UNTESTED: gdb.dlang/dlang-start.exp: failed to prepare ... Fix this by: - introducing a new proc can_compile, and - requiring "can_compile d" in the test-case, such that I have instead: ... Running gdb.dlang/dlang-start.exp ... UNSUPPORTED: gdb.dlang/dlang-start.exp: require failed: can_compile d ... Tested on x86_64-linux, on openSUSE Leap 15.4 and Fedora 37. --- gdb/testsuite/gdb.dlang/dlang-start.exp | 1 + gdb/testsuite/lib/gdb.exp | 16 ++++++++++++++++ 2 files changed, 17 insertions(+) diff --git a/gdb/testsuite/gdb.dlang/dlang-start.exp b/gdb/testsuite/gdb.dlang/dlang-start.exp index fd4688b0635..921f67064d3 100644 --- a/gdb/testsuite/gdb.dlang/dlang-start.exp +++ b/gdb/testsuite/gdb.dlang/dlang-start.exp @@ -17,6 +17,7 @@ load_lib d-support.exp require allow_d_tests +require {can_compile d} # This testcase verifies the behavior of the `start' command, which # does not work when we use the gdb stub... diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index f8046ffe84d..813b755215e 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2461,6 +2461,18 @@ proc allow_d_tests {} { return 1 } +# Return a 1 if we can compile source files in LANG. + +gdb_caching_proc can_compile { lang } { + + if { $lang == "d" } { + set src { void main() {} } + return [gdb_can_simple_compile can_compile_$lang $src executable {d}] + } + + error "can_compile doesn't support lang: $lang" +} + # Return 1 to try Rust tests, 0 to skip them. proc allow_rust_tests {} { if { ![isnative] } { @@ -4634,6 +4646,10 @@ proc gdb_simple_compile {name code {type object} {compile_flags {}} {object obj} set ext "cpp" break } + if { "$flag" eq "d" } { + set ext "d" + break + } } set src [standard_temp_file $name.$ext] set obj [standard_temp_file $name.$postfix] -- 2.35.3