From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id CF9F13858289 for ; Tue, 28 Mar 2023 08:23:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF9F13858289 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 13221219D7 for ; Tue, 28 Mar 2023 08:23:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1679991792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pxgF0FLvtINvkhc+VosRvUP4h8wb4cJXIbXBnwFFkb8=; b=fqC6SI96OLDtv47KQ8dXdsq2mko59nwFEx6Ekfmjw7IJtoc13E9wO9rmwT+V8GwpwZF2z6 cBXfB2R5E2LX+o5YdC13vO+21AtQXsI2APiNzj4I1UfSpkhd519du7bIbMDfineW9WPLft DaPpKSsxKOXgEn8vEYtyvjm8LBdHoQY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1679991792; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pxgF0FLvtINvkhc+VosRvUP4h8wb4cJXIbXBnwFFkb8=; b=MsOP/Lx4Psprt1rJVAPROsRLnzAUXcN50DmF/MD3nFg50KOizS85DhJo1doTPgsSt9cTvk QS6UQBORxv4MUYDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F3D701390D for ; Tue, 28 Mar 2023 08:23:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id gF9XOu+jImSAIAAAMHmgww (envelope-from ) for ; Tue, 28 Mar 2023 08:23:11 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed 1/3] [gdb/testsuite] Unsupport gdb.rust for remote host Date: Tue, 28 Mar 2023 10:23:11 +0200 Message-Id: <20230328082313.19529-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: With test-case gdb.rust/watch.exp and remote host I run into: ... Executing on host: gcc watch.rs -g -lm -o watch (timeout = 300) ... ld:watch.rs: file format not recognized; treating as linker script ld:watch.rs:1: syntax error ... UNTESTED: gdb.rust/watch.exp: failed to prepare ... The problem is that find_rustc returns "" for remote host, so we fall back to gcc, which fails. Fix this by returning 0 in allow_rust_tests for remote host. Tested on x86_64-linux. --- gdb/testsuite/lib/gdb.exp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 14ce39e8ed7..0d064017f09 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2479,6 +2479,11 @@ proc allow_rust_tests {} { return 0 } + if { [is_remote host] } { + # Proc find_rustc returns "" for remote host. + return 0 + } + # The rust compiler does not support "-m32", skip. global board board_info set board [target_info name] base-commit: d75137c755cb2c9b36af5f3aeb1f919b411c8e41 -- 2.35.3