Re: [PATCH] gdb: warn when converting h/w watchpoints to s/w

[Lancelot SIX <lsix@lancelotsix.com>]

Hi Andrew

Thanks for doing this, I find this gives useful information to the user.

When applying the patch I see:

    Applying: gdb: warn when converting h/w watchpoints to s/w
    .git/rebase-apply/patch:197: indent with spaces.
            gdb_test "watch local_a" \
    .git/rebase-apply/patch:208: indent with spaces.
            gdb_test "watch local_a + ival5" \
    .git/rebase-apply/patch:218: indent with spaces.
            gdb_test "watch static_b" \
    .git/rebase-apply/patch:286: indent with spaces.
             "watch ival3 if  count > 1  thread 1 \r\nWatchpoint \[0-9\]*: ival3.*" \
    warning: 4 lines add whitespace errors.

> diff --git a/gdb/testsuite/gdb.arch/amd64-watchpoint-downgrade.c b/gdb/testsuite/gdb.arch/amd64-watchpoint-downgrade.c
> new file mode 100644
> index 00000000000..37aa0f63936
> --- /dev/null
> +++ b/gdb/testsuite/gdb.arch/amd64-watchpoint-downgrade.c
> @@ -0,0 +1,35 @@
> +/* This testcase is part of GDB, the GNU debugger.
> +
> +   Copyright 2023 Free Software Foundation, Inc.
> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> +
> +struct struct_type
> +{
> +  unsigned long long array[100];
> +};
> +
> +struct struct_type global_var;
> +
> +int
> +foo (void)
> +{
> +  return 0;
> +}

I do not think this `foo' function is needed here.  The test passes
without it with main just returning 0.

> +
> +int
> +main ()
> +{
> +  return foo ();
> +}

Best,
Lancelot.