From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 527013858D32 for ; Fri, 31 Mar 2023 15:18:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 527013858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 6519710048EBA for ; Fri, 31 Mar 2023 15:18:51 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id iGWhpIGGpeOVYiGWhpQH9E; Fri, 31 Mar 2023 15:18:51 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ks+IZUaN c=1 sm=1 tr=0 ts=6426f9db a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=jsBSfbCXKLs915CRWbYA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BvyGw9N1U7wIJAJrbffHTrroFrEkLBfOndjj4uJosIw=; b=iK9H8c//+Iojf7GGRHftiLu4b3 QR9LW4VjcVjcSfsMhKGIgWhlwTZjHD/QqWZuGZQWP9hbzdT7CJ0McsyPjWPnrp+O86PMb/YMKP6jT MShfk34863mdCDl/yTOD0UUlk; Received: from 71-211-185-113.hlrn.qwest.net ([71.211.185.113]:45404 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1piGWg-000rOs-R5; Fri, 31 Mar 2023 09:18:50 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [pushed] Fix maybe-uninitialized warning in frame.c Date: Fri, 31 Mar 2023 09:18:39 -0600 Message-Id: <20230331151839.1107973-1-tom@tromey.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.113 X-Source-L: No X-Exim-ID: 1piGWg-000rOs-R5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-113.hlrn.qwest.net (localhost.localdomain) [71.211.185.113]:45404 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_ABUSEAT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: A recent patch caused my system gcc (Fedora 36, so gcc 12.2.1) to warn about sym_addr being possibly uninitialized in frame.c. It isn't, but the compiler can't tell. So, this patch initializes the variable. I also fixed a formatting buglet that I missed in review. --- gdb/frame.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/frame.c b/gdb/frame.c index 4f420f138f6..36fb02f3c8e 100644 --- a/gdb/frame.c +++ b/gdb/frame.c @@ -2537,7 +2537,7 @@ inside_main_func (frame_info_ptr this_frame) if (current_program_space->symfile_object_file == nullptr) return false; - CORE_ADDR sym_addr; + CORE_ADDR sym_addr = 0; const char *name = main_name (); bound_minimal_symbol msymbol = lookup_minimal_symbol (name, NULL, @@ -2573,8 +2573,9 @@ inside_main_func (frame_info_ptr this_frame) /* Convert any function descriptor addresses into the actual function code address. */ - sym_addr = gdbarch_convert_from_func_ptr_addr - (get_frame_arch (this_frame), sym_addr, current_inferior ()->top_target ()); + sym_addr = (gdbarch_convert_from_func_ptr_addr + (get_frame_arch (this_frame), sym_addr, + current_inferior ()->top_target ())); return sym_addr == get_frame_func (this_frame); } -- 2.39.2