From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 4B062385773F for ; Sat, 15 Apr 2023 15:13:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B062385773F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id D536E10048486 for ; Sat, 15 Apr 2023 15:13:43 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id nhaxpjbAORLHZnhaxpKbmH; Sat, 15 Apr 2023 15:13:43 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=IqHbzJzg c=1 sm=1 tr=0 ts=643abf27 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=YUs3E4n6YAQTRT3zijQA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZPaKPXiBNuF1wIOiGIGkZxG+stiKKE6iV/E1bohKa7M=; b=ZWZ5v/cgafCc6Y26rTSCH/li93 ZChHjKJ5NMlzJ5xcO2CeOsehtbConh5gYb4hG8TVc7P7I3m8z7pt0QnfKpEzhfv6skFV6kuWxrB05 XWXkQyTUF+X3NbbTgT+iZ6blT; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:43720 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pnhax-0021Ms-Ia; Sat, 15 Apr 2023 09:13:43 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [RFC 1/5] Bug fix in prepare_for_testing Date: Sat, 15 Apr 2023 09:13:32 -0600 Message-Id: <20230415151336.4104455-2-tom@tromey.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230415151336.4104455-1-tom@tromey.com> References: <20230415151336.4104455-1-tom@tromey.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1pnhax-0021Ms-Ia X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (localhost.localdomain) [71.211.191.82]:43720 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: prepare_for_testing should return the result of clean_restart, but it currently does not. This patch fixes the oversight. --- gdb/testsuite/lib/gdb.exp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 9ea0334759d..a1808c699e9 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -7677,8 +7677,7 @@ proc prepare_for_testing_full {testname args} { } set executable [lindex $spec 0] } - clean_restart $executable - return 0 + return [clean_restart $executable] } # Prepares for testing, by calling build_executable, and then clean_restart. @@ -7688,9 +7687,7 @@ proc prepare_for_testing { testname executable {sources ""} {options {debug}}} { if {[build_executable $testname $executable $sources $options] == -1} { return -1 } - clean_restart $executable - - return 0 + return [clean_restart $executable] } # Retrieve the value of EXP in the inferior, represented in format -- 2.39.2