From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 9C9F93858D28 for ; Tue, 18 Apr 2023 20:27:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C9F93858D28 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=efficios.com Received: from localhost.localdomain (unknown [167.248.160.41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 869E41E15D; Tue, 18 Apr 2023 16:27:52 -0400 (EDT) From: Simon Marchi To: gdb-patches@sourceware.org Cc: Simon Marchi Subject: [PATCH 1/3] gdb: remove return value of set_language Date: Tue, 18 Apr 2023 16:27:49 -0400 Message-Id: <20230418202751.117181-2-simon.marchi@efficios.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230418202751.117181-1-simon.marchi@efficios.com> References: <20230418202751.117181-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1172.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_NONE,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_SOFTFAIL,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: set_language returns the previous language, but nothing uses it. Remove the return value. This lets us remove the assignment to current_language, in _initialize_language. Change-Id: Ifccf9b488434c1addf4626130a74e159a37d8c17 --- gdb/language.c | 14 ++------------ gdb/language.h | 5 +++-- 2 files changed, 5 insertions(+), 14 deletions(-) diff --git a/gdb/language.c b/gdb/language.c index fb065ef6a759..1ab356597d74 100644 --- a/gdb/language.c +++ b/gdb/language.c @@ -353,18 +353,13 @@ set_range_case (void) case_sensitivity = current_language->case_sensitivity (); } -/* Set current language to (enum language) LANG. Returns previous - language. */ +/* See language.h. */ -enum language +void set_language (enum language lang) { - enum language prev_language; - - prev_language = current_language->la_language; current_language = language_def (lang); set_range_case (); - return prev_language; } @@ -1125,11 +1120,6 @@ For Fortran the default is off; for other languages the default is on."), show_case_command, &setlist, &showlist); - /* In order to call SET_LANGUAGE (below) we need to make sure that - CURRENT_LANGUAGE is not NULL. So first set the language to unknown, - then we can change the language to 'auto'. */ - current_language = language_def (language_unknown); - add_set_language_command (); /* Have the above take effect. */ diff --git a/gdb/language.h b/gdb/language.h index 57df8acd0a3b..4c91776d94dc 100644 --- a/gdb/language.h +++ b/gdb/language.h @@ -761,8 +761,9 @@ struct symbol * extern void language_info (); -extern enum language set_language (enum language); - +/* Set the current language to LANG. */ + +extern void set_language (enum language lang); /* Test a character to decide whether it can be printed in literal form or needs to be printed in another representation. For example, -- 2.40.0