From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0.riseup.net (mx0.riseup.net [198.252.153.6]) by sourceware.org (Postfix) with ESMTPS id 1A8703858CDA for ; Wed, 19 Apr 2023 18:16:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A8703858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=riseup.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=riseup.net Received: from fews02-sea.riseup.net (unknown [10.0.1.112]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4Q1psF2JCzz9sSR for ; Wed, 19 Apr 2023 18:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1681928209; bh=ki7JJEVHkvyr+ILV6Ay/ZgXzTwUsh14IurlPKn4OB5Q=; h=Date:From:To:Subject:From; b=pzwD9VJwxUvavms9Ln97ZtbXlkYh03q5h2nOHyVxcA5Yz4GpbgqF80JrAoS4DQKIS p2sGMT5GlgGO+jS0yYfdPq6ZwnWx2eesQxWP3clT3dvG0zriiQNnbcTmrrOXZrMkwi zGyOrESTG8kbdE8peO/AaQ6cbobuehu5D+uZGv7A= X-Riseup-User-ID: 3E934C228139FB6237B46822F019EEAB0E26A1F9C1E80D55AB104AB4CBD85205 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews02-sea.riseup.net (Postfix) with ESMTPSA id 4Q1psF0XHdzFsKG for ; Wed, 19 Apr 2023 18:16:49 +0000 (UTC) Date: Wed, 19 Apr 2023 11:16:28 -0700 From: orbea To: gdb-patches@sourceware.org Subject: [PATCH] gdb: Don't overwrite CC when checking for BFD support Message-ID: <20230419111628.0e1f33f0@Akita> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/RM1SMBffaFkelclg5qsLeiG" X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --MP_/RM1SMBffaFkelclg5qsLeiG Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline In gdb/acinclude.m4 'libtool' is hard coded within the provided custom CC variable which results in a failure when using slibtool instead of GNU libtool where the two different libtool implementations are incompatible when both are used during the same build process at once. This can be solved by using the default value for CC instead where autotools is capable of providing an adequate value by default. I attached a patch doing this. A bug report was issued here: https://sourceware.org/bugzilla/show_bug.cgi?id=30295 Please see comment 3 with the explanation where before I was missing the real issue. --MP_/RM1SMBffaFkelclg5qsLeiG Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=gdb_acinclude_m4.patch commit 31245fcf4fc31e732f05205f739317e9c8922da3 Author: orbea Date: Fri Mar 31 09:46:51 2023 -0700 gdb: Don't overwrite CC when checking for BFD support When building with an alternative libtool implementation such as slibtool the configure check for BFD features will fail in gdb/configure.ac because './libtool' was hardcoded. Simply removing the line allows the configure check to work correctly. diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4 index 173e40b440..5f7589f9f6 100644 --- a/gdb/acinclude.m4 +++ b/gdb/acinclude.m4 @@ -237,7 +237,6 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [ LDFLAGS="-L../bfd -L../libiberty $LDFLAGS" intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'` LIBS="-lbfd -liberty $intl $LIBS" - CC="./libtool --quiet --mode=link $CC" AC_CACHE_CHECK( [$1], [$2], --MP_/RM1SMBffaFkelclg5qsLeiG--