From: Sandra Loosemore <sandra@codesourcery.com>
To: <gdb-patches@sourceware.org>
Cc: <tom@tromey.com>
Subject: [PATCH V2 4/5] gdb/testsuite: Disable some tests that are broken on remote Windows host
Date: Sun, 23 Apr 2023 13:36:05 -0600 [thread overview]
Message-ID: <20230423193606.576453-1-sandra@codesourcery.com> (raw)
These testcases assume host==build or that the remote host has a Posix
shell to run commands in. Don't try to run them if that's not the case.
---
gdb/testsuite/gdb.base/bad-file.exp | 3 +++
gdb/testsuite/gdb.base/early-init-file.exp | 3 +++
gdb/testsuite/gdb.base/empty-host-env-vars.exp | 3 +++
3 files changed, 9 insertions(+)
diff --git a/gdb/testsuite/gdb.base/bad-file.exp b/gdb/testsuite/gdb.base/bad-file.exp
index 5d8dfee8fea..5e050411f95 100644
--- a/gdb/testsuite/gdb.base/bad-file.exp
+++ b/gdb/testsuite/gdb.base/bad-file.exp
@@ -20,6 +20,9 @@
# print different text then the plan is to update the expected text
# instead of making this test linux-only or some such.
+# The pathnames and shell commands in this test don't work on Windows host.
+require {!ishost *-*-mingw*}
+
# There is no such file, but we still use the normal mechanism to pick
# its name and path.
standard_testfile
diff --git a/gdb/testsuite/gdb.base/early-init-file.exp b/gdb/testsuite/gdb.base/early-init-file.exp
index fcd1ff041a1..237439f9db7 100644
--- a/gdb/testsuite/gdb.base/early-init-file.exp
+++ b/gdb/testsuite/gdb.base/early-init-file.exp
@@ -15,6 +15,9 @@
# Test GDB's early init file mechanism.
+# Test assumes host == build.
+require {!is_remote host}
+
standard_testfile
# Compile the test executable.
diff --git a/gdb/testsuite/gdb.base/empty-host-env-vars.exp b/gdb/testsuite/gdb.base/empty-host-env-vars.exp
index 96240311c24..22f6b4d2ebe 100644
--- a/gdb/testsuite/gdb.base/empty-host-env-vars.exp
+++ b/gdb/testsuite/gdb.base/empty-host-env-vars.exp
@@ -13,6 +13,9 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
+# This test assumes host == build.
+require {!is_remote host}
+
# GDB reads some environment variables on startup, make sure it behaves
# correctly if these variables are defined but empty.
--
2.31.1
next reply other threads:[~2023-04-23 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 19:36 Sandra Loosemore [this message]
2023-04-23 19:36 ` [PATCH V2 5/5] gdb/testsuite: Make hook-stop.exp ignore termination message from GDB stub Sandra Loosemore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230423193606.576453-1-sandra@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).