From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id A9BB63858409 for ; Mon, 24 Apr 2023 09:29:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9BB63858409 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AAA3B21994 for ; Mon, 24 Apr 2023 09:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682328592; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7lK4VgF+BpDhQxmA1u/A8qcRkvNhL5SiKO+GR1Wz4R8=; b=V3eChmrqSvwHsU65pBVV8YtkRv0M3I+j6qYAwCiHfqOgqCsjtWvCbezYH8yE8f46FTGNo+ jhFQHUVuqm81tnPdS/a4IoFL9cWvcz2I91iPb2/lxlnmvM4jYvrlXGGvWhnAZa5QNhWnsV iads+HG30eFUEcVjLOLpwp3OzP4d/8o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682328592; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7lK4VgF+BpDhQxmA1u/A8qcRkvNhL5SiKO+GR1Wz4R8=; b=Ht+NaflaXxHg5bDqTICOQl5P6XdZSqGiR5LwIAheQRpTCuQCBcMsaJCXS8ouEFeIv62LtW 9cwwT8ihfQ5vXwBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 96C5313780 for ; Mon, 24 Apr 2023 09:29:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ol5lIxBMRmRQDQAAMHmgww (envelope-from ) for ; Mon, 24 Apr 2023 09:29:52 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed] [gdb/testsuite] Skip dap tests for tcl 8.5 Date: Mon, 24 Apr 2023 11:29:53 +0200 Message-Id: <20230424092953.19953-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When running the dap tests on a system with tcl 8.5, we run into: ... ERROR: tcl error sourcing gdb/testsuite/gdb.dap/memory.exp. ERROR: bad class "entier": must be alnum, alpha, ascii, control, boolean, \ digit, double, false, graph, integer, list, lower, print, punct, space, \ true, upper, wideinteger, wordchar, or xdigit while executing "string is entier $num" (procedure "num" line 16) invoked from within ... Fix this by: - requiring tcl 8.6 in allow_dap_tests, and - adding the missing require allow_dap_tests in gdb.dap/memory.exp. Tested on x86_64-linux. --- gdb/testsuite/gdb.dap/memory.exp | 2 ++ gdb/testsuite/lib/gdb.exp | 5 +++++ 2 files changed, 7 insertions(+) diff --git a/gdb/testsuite/gdb.dap/memory.exp b/gdb/testsuite/gdb.dap/memory.exp index fec552c4124..ab0516d6b3d 100644 --- a/gdb/testsuite/gdb.dap/memory.exp +++ b/gdb/testsuite/gdb.dap/memory.exp @@ -15,6 +15,8 @@ # Test DAP read/write memory. +require allow_dap_tests + load_lib dap-support.exp standard_testfile diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 9ea0334759d..b59b4358ca4 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -2515,6 +2515,11 @@ gdb_caching_proc allow_dap_tests {} { return 0 } + # ton.tcl uses "string is entier", supported starting tcl 8.6. + if { ![tcl_version_at_least 8 6] } { + return 0 + } + # With set auto-connect-native-target off, we run into: # +++ run # Traceback (most recent call last): base-commit: d4a174a5cbb794143164897a4e8a08972fd251a1 -- 2.35.3