From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 3A7E03858C83 for ; Mon, 24 Apr 2023 12:48:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3A7E03858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 719401FD83 for ; Mon, 24 Apr 2023 12:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682340525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=w4qMIKvcQF4upimzKU8qCQrHjGaR9Hk/zweNY8wzMvk=; b=lbtrZ+jBTVQk9dmx1UhUbLPpClYj8M00t6SrR75T3RV+79jXMr5gfGuDMcDu6l+cAx+rS+ G58/VOgZ3oEFwdVDSeG+IGd/8jSRX4Li71gCfcZUnN9qpYje6GmoI++PQSOO0rOLpcTXtD PLDCjhrCthQU1Auu5GkrQXzqTQahNj8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682340525; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=w4qMIKvcQF4upimzKU8qCQrHjGaR9Hk/zweNY8wzMvk=; b=wfCN9StUcQcSmhRQCa/umDp2Czz5V6a1sqHqivY1H5UdvAlUBZNjRsM27qevKTTHhGeEuH dEEjrz4ZmCwKcEDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C2DA1390E for ; Mon, 24 Apr 2023 12:48:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fPMjFa16RmRdBAAAMHmgww (envelope-from ) for ; Mon, 24 Apr 2023 12:48:45 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed 1/4] [gdb/testsuite] Don't use string cat in gdb.dwarf2/dw2-abs-hi-pc.exp Date: Mon, 24 Apr 2023 14:48:43 +0200 Message-Id: <20230424124846.29580-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Test-case gdb.dwarf2/dw2-abs-hi-pc.exp uses string cat: ... set sources [lmap i $sources { string cat "${srcdir}/${subdir}/" $i }] ... but that's only supported starting tcl 8.6. Fix this by using "expr" instead: ... set sources [lmap i $sources { expr { "$srcdir/$subdir/$i" } }] ... Tested on x86_64-linux. --- gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp b/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp index 0868b69f15e..2ea6a5cea00 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp +++ b/gdb/testsuite/gdb.dwarf2/dw2-abs-hi-pc.exp @@ -24,7 +24,8 @@ set sources \ ${testfile}.c \ ${testfile}-hello.c \ ${testfile}-world.c] -set sources [lmap i $sources { string cat "${srcdir}/${subdir}/" $i }] +set sources [lmap i $sources { expr { "$srcdir/$subdir/$i" } }] + lassign [function_range hello $sources] \ hello_start hello_len lassign [function_range world $sources] \ base-commit: ea5c591c023544e40bb4967314a47d8e6a1e806d -- 2.35.3