From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by sourceware.org (Postfix) with ESMTPS id 990883858D1E for ; Mon, 24 Apr 2023 16:22:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 990883858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2a.google.com with SMTP id ca18e2360f4ac-763c34315c1so116490039f.3 for ; Mon, 24 Apr 2023 09:22:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1682353342; x=1684945342; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=XlVn3UMtp74XiL5NQilggnf3QspbM/ps1TM5woLVHH4=; b=KbEI9fpHeWwSZmZAV00wsFfrQ2rsRWp0ZbGDU6lSlqg1rUlGilZzDI12WFUurftUgK PtENMh19KKPo9ofbFHYniuLjBuVG3gavdBUZCAj839vQfzkxKpqxHNvnw5GbNuplVQqX 5W75EuRtdNUPr13/FG8596vjHsuxJ7DoN1v03QIGvZMvKysqZLh/4ro0sLYMdwvjQYVI 1WzeJtriQDpiAt1sCPbfxeBxHPMl4SWbng2DnI/gjuSSM1Ry5QIQev+KGr3cGDkg31z5 kzkKOhQRUobglO+1D5uKrV8O1qKLLYKUtlc4GinEEZ3/z2NsiLwyZCzQG8aS16oH4Ssr ayrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682353342; x=1684945342; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XlVn3UMtp74XiL5NQilggnf3QspbM/ps1TM5woLVHH4=; b=W7b9mCrwR9juQwtHMe9AFabsBF6YK8FCpEo6M5LdJGD4IBFhY9xAajp8o/m66sNKY/ LCswKUulT6diS5i4xCgJ1aGS+CXX+JFP4eBUAEHaOa+/BghoxT/5etpazTTA9ikSZ8fi 9rBYhweI1FsSoQ8K706pAsLUMn0mahWqC1fRMMcTSZmZczyqqg5lL5uK7EFp3g40hL+k oGJam+P87Z9f3G+jOzppxSD4F/n7LdTWhEnYYHg0ENSvyaoYGllOjmHau32Qjo27PqJV JM1Z/1OUgJOD13VrX2oS60ixMxVAfShVs6q8YPKW0tJbR1tlGyElTCcsdqqa+pIFimG7 3dgg== X-Gm-Message-State: AAQBX9e1Azgz1kdGG2GYJs9CcVf62w4pxxh4e3SeDQCurc84pVieWMRz 2c+8YF1MjEqfZ8Sg01g+DgCZHwtcVQkNpjfvjJF8sA== X-Google-Smtp-Source: AKy350Zs3ICtSVkzf8Pxby3etcTf08wmBvLd98eERC3N6JHOsh7xngsHAdzVufL+nDXPPfxApj2GiA== X-Received: by 2002:a5e:cb09:0:b0:763:5cf8:65eb with SMTP id p9-20020a5ecb09000000b007635cf865ebmr6142756iom.9.1682353341828; Mon, 24 Apr 2023 09:22:21 -0700 (PDT) Received: from localhost.localdomain (71-211-191-82.hlrn.qwest.net. [71.211.191.82]) by smtp.gmail.com with ESMTPSA id cx27-20020a056638491b00b0040fa19472bcsm3444049jab.92.2023.04.24.09.22.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Apr 2023 09:22:21 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Subject: [RFC 00/10] More use of unrelocated_addr Date: Mon, 24 Apr 2023 10:22:01 -0600 Message-Id: <20230424162211.682763-1-tromey@adacore.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: While working on a different patch, I decided to add more use of unrelocated_addr to the DWARF reader. This caught at least one latent bug, see patch #10. (I thought there was another one as well, but I can't find it now.) The main ugliness here is that it adds a lot of casts. Partly (but not entirely) this is due to the decision to not use DEFINE_OFFSET_TYPE for unrelocated_addr. Maybe it would be better to write a custom wrapper class for unrelocated_addr instead. I moved unrelocated_addr to gdbsupport, but maybe it would be better in defs.h. I'm not sure. Regression tested on x86-64 Fedora 36. Let me know what you think. Tom