From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1663F3858C74 for ; Fri, 28 Apr 2023 16:07:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1663F3858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682698067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VpWQpr7iPP+qPrHqBqKleDsycMPrDQtQxKjk1ieY2UM=; b=Kxon0TRw4Nw/q5G6lQqB9nnT/wyfhmpuvJ7lt1DQqZQS9DXephhMAPU3bt+dMV3dwf9ygI JG63wkGWNrqMBVNYLeHGgIY0t4VdojEoWQaEAoy7Z4YRhDM0VlzzEIE7/ypIO3UKJpMVgU Un2El7z3Im2QJKfIPmWYH6RX2xGbIUM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-362-xRhAgHL6PgeFZCTo_x4Vbw-1; Fri, 28 Apr 2023 12:07:42 -0400 X-MC-Unique: xRhAgHL6PgeFZCTo_x4Vbw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 97B843C025CB; Fri, 28 Apr 2023 16:07:41 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.10.82]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B5FF4043AC4; Fri, 28 Apr 2023 16:07:41 +0000 (UTC) Date: Fri, 28 Apr 2023 09:07:39 -0700 From: Kevin Buettner To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Do not change type in get_discrete_low_bound Message-ID: <20230428090739.4928deb1@f37-zws-nv> In-Reply-To: <20230427193515.1060101-1-tromey@adacore.com> References: <20230427193515.1060101-1-tromey@adacore.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 27 Apr 2023 13:35:15 -0600 Tom Tromey via Gdb-patches wrote: > get_discrete_low_bound has this code: > > /* Set unsigned indicator if warranted. */ > if (low >= 0) > type->set_is_unsigned (true); > > It's bad to modify a type in a getter like this, so this patch removes > this code. FWIW I looked and this code has been there since at least > 1999 (it was in the initial sourceware import). LGTM. Reviewed-by: Kevin Buettner