From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id B2CB13858CDB for ; Sat, 29 Apr 2023 05:04:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2CB13858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 663981FD77 for ; Sat, 29 Apr 2023 05:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682744674; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e7cq6duYffNoswcM40CtpgCVxHEqufFRKcKJNcEd/BU=; b=AVqp4p3KYPRzpAAhG5+uGVhRmyi77sO86Vv6PWrG5fpUVgMXBDjRmZ2f4r6MoHrs3YKYiM zILk37y420dxd5TJrQrvYLgT32R9qM7O7be+aXcHU+JVRT3jpIKH3sMhhIJuAWstwXqdjA aGaAXKuVvgphUIxksYGi7/41OEFP4Yg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682744674; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=e7cq6duYffNoswcM40CtpgCVxHEqufFRKcKJNcEd/BU=; b=0Ku4eFw9iYCNxSwNNLsQow9Jxsqvo9AbxfAQNwsxvsg7votFUCjOQOzraSGseu/AFJMFJU sHr5oAf5yz6PuoDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 525EE13587 for ; Sat, 29 Apr 2023 05:04:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1v32EmKlTGQ5KQAAMHmgww (envelope-from ) for ; Sat, 29 Apr 2023 05:04:34 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed] [gdb/build] Fix build without ncurses in maintenance_info_screen Date: Sat, 29 Apr 2023 07:04:48 +0200 Message-Id: <20230429050448.11802-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: With a build without ncurses we run into: ... src/gdb/utils.c: In function ‘void maintenance_info_screen(const char*, int)’: src/gdb/utils.c:1310:7: error: ‘COLS’ was not declared in this scope COLS); ^~~~ src/gdb/utils.c:1331:8: error: ‘LINES’ was not declared in this scope LINES); ^~~~~ ... Fix this by using HAVE_LIBCURSES. Tested on x86_64-linux. PR build/30391 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30391 --- gdb/utils.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gdb/utils.c b/gdb/utils.c index b5bb84ce85d..002a5885aff 100644 --- a/gdb/utils.c +++ b/gdb/utils.c @@ -1304,10 +1304,12 @@ maintenance_info_screen (const char *args, int from_tty) ? " (unlimited - 1)" : ""))); +#ifdef HAVE_LIBCURSES gdb_printf (gdb_stdout, _("Number of characters curses thinks " "are in a line is %d.\n"), COLS); +#endif gdb_printf (gdb_stdout, _("Number of characters environment thinks " @@ -1325,10 +1327,12 @@ maintenance_info_screen (const char *args, int from_tty) rows, rows == sqrt_int_max ? " (unlimited)" : ""); +#ifdef HAVE_LIBCURSES gdb_printf (gdb_stdout, _("Number of lines curses thinks " "are in a page is %d.\n"), LINES); +#endif gdb_printf (gdb_stdout, _("Number of lines environment thinks " base-commit: 1b05f1083a4e18e5141ddce7551b79d07d9b272d -- 2.35.3