From: Bruno Larsen <blarsen@redhat.com>
To: gdb-patches@sourceware.org
Cc: Bruno Larsen <blarsen@redhat.com>
Subject: [PATCH] Revert "gdb/testsuite: add KFAILs to gdb.reverse/step-reverse.exp"
Date: Thu, 4 May 2023 12:50:22 +0200 [thread overview]
Message-ID: <20230504105022.585919-1-blarsen@redhat.com> (raw)
This reverts commit 476410b3bca1389ee69e9c8fa18aaee16793a56d.
One of Simon's recent commits (2a740b3ba4c9f39c86dd75e0914ee00942cab471)
changed the way recording a remote target works and fixed the underlying
issue of the bug, so the KFails can be removed from the test.
---
gdb/testsuite/gdb.reverse/step-reverse.exp | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/gdb/testsuite/gdb.reverse/step-reverse.exp b/gdb/testsuite/gdb.reverse/step-reverse.exp
index 2c3b95a2eae..729218d4cb8 100644
--- a/gdb/testsuite/gdb.reverse/step-reverse.exp
+++ b/gdb/testsuite/gdb.reverse/step-reverse.exp
@@ -29,7 +29,6 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile] } {
}
runto_main
-set target_remote [gdb_is_target_remote]
if [supports_process_record] {
# Activate process record/replay
@@ -272,25 +271,11 @@ if { "$step_out" == 1 } {
# Step forward over recursion again so we can test stepping over calls
# inside the recursion itself.
gdb_test_no_output "set exec-dir forward" "forward again to test recursion"
-if {$target_remote} {
- # gdb doesn't record the change of return pointer for remote targets,
- # so we can't next forward over functions.
- setup_kfail gdb/29745 *-*-*
-}
gdb_test "next" "NEXT OVER THIS CALL.*" "reverse next over recursion again"
gdb_test_no_output "set exec-dir reverse" "reverse again to test recursion"
-if {$target_remote} {
- # Because of the above mentioned KFAIL, the inferior is now out of sync
- setup_kfail gdb/29745 *-*-*
-}
gdb_test "step" ".*EXIT RECURSIVE FUNCTION.*" "enter recursive function"
set seen_recursive_call 0
-if {$target_remote} {
- # Because of the above mentioned KFAIL, the inferior is now out of sync
- # The fail state below will resync the inferior.
- setup_kfail gdb/29745 *-*-*
-}
gdb_test_multiple "next" "step over recursion inside the recursion" {
-re -wrap ".*RECURSIVE CALL.*" {
incr seen_recursive_call
--
2.40.0
next reply other threads:[~2023-05-04 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 10:50 Bruno Larsen [this message]
2023-05-04 14:46 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230504105022.585919-1-blarsen@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).