Re: [PATCH] gdb/DAP: Add customRequest

[Lancelot SIX <lsix@lancelotsix.com>]

Hi Simon,

I have a couple of remarks below.

> +@request("customRequest")
> +def custom_request_handler(**args):

It looks like the args dict must contain the "command" and "args".  I
would find it clearer if this was stated in the function definition like
so:

def custom_request_handler(*, command, args):

If args can contain more keys (which will be ignored by the
implementation), it could be:

def custom_request_handler(*, command, args, **kwargs):

> +    global _custom_requests
> +    cmd = args["command"]
> +    if _custom_requests.get(cmd) is not None:
> +        return _custom_requests[cmd](args["args"])

Just a nit, but the cmd lookup could be done just once:

cmd = _custom_requests.get(command)
if cmd is not None:
    return cmd(args)

Also see Tom's comment regarding which thread you want this to execute
in.  This part could become

    return send_gdb_with_response(lambda: cmd(args))

> +    else:
> +        raise Exception(f"Unrecognized customRequest {cmd}")

I am not sure we guarantee python >= 3.6, so f-strings might not be
available.  That being said, as python-3.6 istelf is not supported
anymore we could maybe just bump the required version.

Best,
Lancelot.