From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id B3BAA3882048 for ; Fri, 12 May 2023 09:44:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B3BAA3882048 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E31F42048D for ; Fri, 12 May 2023 09:44:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683884653; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9X7b+L0juAVdPX9yAeK3RvG8p9xdP4z7vqCZlqRN4tY=; b=eNG+w9piUCzBOHwZHeavq9g1tP7HtzORotp8hQjObgl0TqBhzn6aHBK4PX3Z9YT6Cjql3v /pStgWsTpXzVPXFmjdfMZT+VaybBzIv9Vp4Vd8YEK2KncDuYf8qo/yQWr7pzlo/oAQFIT0 m4ruzeecTMMfo/mIUOppDSk7cJZ3wY4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683884653; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9X7b+L0juAVdPX9yAeK3RvG8p9xdP4z7vqCZlqRN4tY=; b=bUvc5Pe4DWfZjorxj9E+FsjI9xHzKGiY6ZKuxDllQG1WpawavA2fM0Jx8PLFHwNWU2rrv9 l5DvfxrfrMC1tFAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A34EB13499 for ; Fri, 12 May 2023 09:44:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8BfZI20KXmStSgAAMHmgww (envelope-from ) for ; Fri, 12 May 2023 09:44:13 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [pushed 2/2] [gdb/testsuite] Fix gdb.dwarf2/opt-out-not-implptr.exp for -m32 Date: Fri, 12 May 2023 11:44:11 +0200 Message-Id: <20230512094412.24801-2-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230512094412.24801-1-tdevries@suse.de> References: <20230512094412.24801-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When running test-case gdb.dwarf2/opt-out-not-implptr.exp with target board unix/-m32 we have: ... (gdb) print noptr^M $1 = {0, , , }^M (gdb) FAIL: gdb.dwarf2/opt-out-not-implptr.exp: print noptr ... The problem happens when evaluating this dwarf expression: ... <45> DW_AT_location : 13 byte block: 10 86 ea d7 d0 96 8e cf 92 5c 9f 93 8 \ (DW_OP_constu: 6639779683436459270; DW_OP_stack_value; DW_OP_piece: 8) ... The DW_OP_constu pushes a value with "generic type" on to the DWARF stack, and the "generic type" has the size of an address on the target machine, which for target board unix/-m32 is 4 bytes. Consequently, the constant is abbreviated. Next, the DW_OP_piece declares that the resulting 4-byte value is 8 bytes large, and we hit this clause in rw_pieced_value: ... /* Use zeroes if piece reaches beyond stack value. */ if (p->offset + p->size > stack_value_size_bits) break; ... and consequently get a zero. We could just add require is_target_64 to the test-case, but instead, add a 32-bit case and require is_target_64 just for the 64-bit case. Tested on x86_64-linux. --- .../gdb.dwarf2/opt-out-not-implptr.exp | 52 ++++++++++++++++--- 1 file changed, 45 insertions(+), 7 deletions(-) diff --git a/gdb/testsuite/gdb.dwarf2/opt-out-not-implptr.exp b/gdb/testsuite/gdb.dwarf2/opt-out-not-implptr.exp index 949bc23492a..9b240c9a2af 100644 --- a/gdb/testsuite/gdb.dwarf2/opt-out-not-implptr.exp +++ b/gdb/testsuite/gdb.dwarf2/opt-out-not-implptr.exp @@ -21,10 +21,13 @@ standard_testfile main.c -dw.S set asm_file [standard_output_file $srcfile2] +set c64 6639779683436459270 +set c32 1779823878 + Dwarf::assemble $asm_file { cu {} { compile_unit {} { - declare_labels i64_type array + declare_labels i64_type i32_type i64_array i32_array i64_type: base_type { {name "int64_t"} @@ -32,7 +35,13 @@ Dwarf::assemble $asm_file { {byte_size 8 DW_FORM_sdata} } - array: DW_TAG_array_type { + i32_type: base_type { + {name "int32_t"} + {encoding @DW_ATE_signed} + {byte_size 4 DW_FORM_sdata} + } + + i64_array: DW_TAG_array_type { {DW_AT_name array_type} {DW_AT_type :$i64_type} } { @@ -43,15 +52,36 @@ Dwarf::assemble $asm_file { } } + i32_array: DW_TAG_array_type { + {DW_AT_name array_type} + {DW_AT_type :$i32_type} + } { + DW_TAG_subrange_type { + {DW_AT_type :$i32_type} + {DW_AT_lower_bound 0 DW_FORM_data1} + {DW_AT_upper_bound 3 DW_FORM_data1} + } + } + DW_TAG_variable { - {name noptr} - {type :$array} + {name i64_noptr} + {type :$i64_array} {location { - DW_OP_constu 6639779683436459270 + DW_OP_constu $::c64 DW_OP_stack_value DW_OP_piece 8 } SPECIAL_expr} } + + DW_TAG_variable { + {name i32_noptr} + {type :$i32_array} + {location { + DW_OP_constu $::c32 + DW_OP_stack_value + DW_OP_piece 4 + } SPECIAL_expr} + } } } } @@ -72,5 +102,13 @@ if {![runto_main]} { return -1 } -gdb_test "print noptr" \ - " = \\{6639779683436459270, , , \\}" +set cmd "print i64_noptr" +if { [is_64_target] } { + gdb_test $cmd \ + " = \\{$c64, , , \\}" +} else { + unsupported $cmd +} + +gdb_test "print i32_noptr" \ + " = \\{$c32, , , \\}" -- 2.35.3