From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by sourceware.org (Postfix) with ESMTPS id EFE663858C50 for ; Mon, 15 May 2023 15:14:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EFE663858C50 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=flex--ppluzhnikov.bounces.google.com Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-b8f32cc8c31so23613502276.2 for ; Mon, 15 May 2023 08:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684163675; x=1686755675; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=8u/JyWDDmbILgGW7+Lw02f6NJhEaKH2ODI6jDQfJX/0=; b=HfRBj8R/9wMixM+s7Afavr1qTInVtl8V5AZO+hmrMtQcj3ACDHf8r1lyQB/crUooIV Rk/3vR3A5trEE6A+yVFraxrcQdvTMzaj+pjejgTL6ejRa3Y3Rxu+BzwQ/Wud1Vr7bdZQ RMs5yk1JGfnrwbbu6P46H/XgBGg3n6xlPrtCH1j2CZXy+XrRJr8wxQcO541AgTg4PRWe 6PeetQhC3vAh2QxqOo8rrIwIfLkCfhRi3pNgti1QqPoZTQ1M3Cy5Ar2EZczASzHZDIcn GCrjQmazd997VNqKJEIDqVMzTqzONuTYCLsms+jXzJsVTAvCXjeRwYFVZyrl0E4yNbWI USBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684163675; x=1686755675; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8u/JyWDDmbILgGW7+Lw02f6NJhEaKH2ODI6jDQfJX/0=; b=WiuaAZTpzj+XRKaAmll04L2UZ84yX99bhZRfRrcxWKjQYWoyjT/uDKSmkTnl93EpHL K4pw/yzscdr2wQZkKcMpREC/feWL4znvrNJnZ4ZLnQAwBbKP0pZhcXcPB970/Yc8cYvn 7ID1J/JB5JrkcknqohsnqjAKdU1P5mhUG+SkADRANZ0a6AVz3V1/YHr4kUuQ1jgcyDhl sx4wkdrD95KhY5Vt7N+aJC5M3ARXBqYkr+yydALy5uk0/zv8OWcZ0lnaW2dShY3wUAPD OGsOAdKlvCptC4ZtFeQNCe5i8ljxTn95A6/EcddPe/r/9CZxPGq0649kxAbeoIeCeyqM +eDA== X-Gm-Message-State: AC+VfDw/YKeJ7Qhuf6ehX6ijPh9KtGeShamZq6Y6F7CJDqRJvmX4lEr2 js464F8ypGDNrxpsfZfWeXVnraOzbNEf3iTiG73y9cUd9C0mtw6Rum19RFGAtK4ABXxwg4NmSqH WizGFyZwIqCCkujyq/ucxVaf1vmYa90bTT8EbgKGNahUc0Ie8HruFE6fl7WA2IqraFUMxPmc4Vq Kk2LE1 X-Google-Smtp-Source: ACHHUZ6UvXkrLZWSQNUC196YW1bcr1vPr8hrZPR55LbIT2eortvH+YPl0fQegcd7PvbYmku5MlfeY1DfwXABv8FXrQ== X-Received: from elbrus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:12e9]) (user=ppluzhnikov job=sendgmr) by 2002:a5b:5c8:0:b0:ba1:919a:8f08 with SMTP id w8-20020a5b05c8000000b00ba1919a8f08mr14450414ybp.2.1684163675233; Mon, 15 May 2023 08:14:35 -0700 (PDT) Date: Mon, 15 May 2023 15:13:00 +0000 In-Reply-To: <87a5y653qq.fsf@redhat.com> Mime-Version: 1.0 References: <87a5y653qq.fsf@redhat.com> X-Mailer: git-send-email 2.40.1.606.ga4b1b128d6-goog Message-ID: <20230515151300.3188497-1-ppluzhnikov@google.com> Subject: [PATCH] Update comments for the gdb/24331 fix. From: Paul Pluzhnikov To: gdb-patches@sourceware.org Cc: Keith Seitz , Andrew Burgess , Paul Pluzhnikov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-20.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, May 15, 2023 at 2:43=E2=80=AFAM Andrew Burgess wrote: > > It's fine to reference the bug, but could you expand this comment to say > what's actually being tested, e.g. Sorry, I've already committed previous patch. Ok to commit this one? Thanks, --- gdb/testsuite/gdb.base/printcmds.exp | 5 ++++- gdb/testsuite/gdb.python/py-format-string.exp | 2 -- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/gdb/testsuite/gdb.base/printcmds.exp b/gdb/testsuite/gdb.base/= printcmds.exp index f2be549f2a5..2506f745f20 100644 --- a/gdb/testsuite/gdb.base/printcmds.exp +++ b/gdb/testsuite/gdb.base/printcmds.exp @@ -1077,7 +1077,10 @@ proc test_repeat_bytes {} { } } =20 -# Test for BZ#24331 +# Test that 'set elements' correctly limits the number of characters +# printed from a string when a string ends with repeated characters. +# This is gdb/24331 + proc test_repeat_bytes_limit {} { gdb_test "print -elem 3 -- \"AAAAA\"" "=3D \"AAA\"..." gdb_test "print -char 3 -elem 10 -- \"AAAAA\"" "=3D \"AAA\"..." diff --git a/gdb/testsuite/gdb.python/py-format-string.exp b/gdb/testsuite/= gdb.python/py-format-string.exp index 2a011ebd45a..55a37766bff 100644 --- a/gdb/testsuite/gdb.python/py-format-string.exp +++ b/gdb/testsuite/gdb.python/py-format-string.exp @@ -745,8 +745,6 @@ proc test_max_string_one { setting unlimited } { "${default_pointer_regexp} \"hel\"..." check_format_string "a_binary_string" $opts \ "${default_pointer_regexp} \"hel\"..." - # This will print four characters instead of three, see - # . check_format_string "a_binary_string_array" $opts \ "\"hel\"..." check_format_string "a_big_string" $opts \ --=20 2.40.1.606.ga4b1b128d6-goog