From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 15BC0385842B for ; Mon, 22 May 2023 13:15:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 15BC0385842B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 31D951FF0C; Mon, 22 May 2023 13:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1684761344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUYyqEI4FnWDWtJPKWnuGcgYJA1GP+cBmyoKd0yWhy8=; b=W9Vio6cK232coFE3T6MBTn2ghy03LnRb56HAJxKzdYGrvXhgxRM6GXKbBoGXxC12IKNDR6 g69D1Neep7soa1iYO4GWVJmOhRL9pBH9drMUQgykJKZwWmJ8SNMw22u0bguh1HCbxiffnp ilGjADfq1tGxXTjLrfAdmRrPnkP1yis= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1684761344; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DUYyqEI4FnWDWtJPKWnuGcgYJA1GP+cBmyoKd0yWhy8=; b=wuKiHF5nsdx/qEh2A1kUMinb6nCSlGnOmXkKDhl7uvIAjQ/j4F1Xxgf9ag7vPBTOMfcVNF 5FhyawnNeeoxzbCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1865913776; Mon, 22 May 2023 13:15:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EMjcBABra2RvdAAAMHmgww (envelope-from ); Mon, 22 May 2023 13:15:44 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH 1/6] [gdb/testsuite] Use TERM=dummy in gdb.tui/tuiterm.exp Date: Mon, 22 May 2023 15:15:39 +0200 Message-Id: <20230522131545.12291-2-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230522131545.12291-1-tdevries@suse.de> References: <20230522131545.12291-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In test-case gdb.tui/tuiterm.exp we have: ... proc setup_terminal { cols rows } { setenv TERM ansi ... The TERM environment variable is used to tell applications about the capabilities of a terminal, but it generally doesn't actually influence the behaviour of the terminal. In this test-case we test the tuiterm instead of applications, and tuiterm also works the same regardless of the TERM setting. Set TERM explictly to dumb and add a comment to avoid giving the impression that the setting matters for the tuiterm behaviour. Tested on x86_64-linux. --- gdb/testsuite/gdb.tui/tuiterm.exp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.tui/tuiterm.exp b/gdb/testsuite/gdb.tui/tuiterm.exp index 6cc6c628e73..8cd15cb33bb 100644 --- a/gdb/testsuite/gdb.tui/tuiterm.exp +++ b/gdb/testsuite/gdb.tui/tuiterm.exp @@ -55,7 +55,13 @@ proc check { test expected_contents expected_cur_col expected_cur_row } { } proc setup_terminal { cols rows } { - setenv TERM ansi + # The TERM environment variable is used to tell applications about the + # capabilities of a terminal, but it generally doesn't actually influence + # the behaviour of the terminal. In this test-case we test the tuiterm, + # which behaves the same regardless of TERM setting. + # Set TERM explictly to dumb to avoid giving the impression that the + # setting matters for the tuiterm behaviour. + setenv TERM dumb Term::_setup $rows $cols } -- 2.35.3