public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH 0/3] [gdb/tui] Improve handling of inferior output
Date: Tue, 30 May 2023 12:53:21 +0200	[thread overview]
Message-ID: <20230530105324.23089-1-tdevries@suse.de> (raw)

When inferior output in TUI causes scrolling, the TUI screen is garbled.  This
is a known issue, PR tui/14332.

This can be fixed manually by doing ^L.

I noticed though that doing ^L removes the inferior output.

The first patch fixes this.

The third patch automates doing ^L when the gdb_tty_state changes to
target_terminal_state::is_ours, such what we no longer have to do ^L.

The second patch is an infrastructure patch used by the third patch.

Tested on x86_64-linux.

Tom de Vries (3):
  [gdb/tui] Keep inferior output in cmd window with ^L
  [gdb] Add observable terminal_owner_changed
  [gdb/tui] Refresh on target_terminal_state::is_ours

 gdb/inflow.c                    | 176 ++++++++++++++++++--------------
 gdb/observable.c                |   1 +
 gdb/observable.h                |   5 +
 gdb/testsuite/gdb.tui/hello.c   |  25 +++++
 gdb/testsuite/gdb.tui/hello.exp |  54 ++++++++++
 gdb/tui/tui-hooks.c             |  11 ++
 gdb/tui/tui-io.c                |   2 +-
 gdb/tui/tui-win.c               |  18 +++-
 gdb/tui/tui-win.h               |   2 +-
 gdb/tui/tui-wingeneral.c        |   5 +-
 gdb/tui/tui-wingeneral.h        |   2 +-
 11 files changed, 214 insertions(+), 87 deletions(-)
 create mode 100644 gdb/testsuite/gdb.tui/hello.c
 create mode 100644 gdb/testsuite/gdb.tui/hello.exp


base-commit: 796029320e75a141570220224731c8151311f8d9
-- 
2.35.3


             reply	other threads:[~2023-05-30 10:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 10:53 Tom de Vries [this message]
2023-05-30 10:53 ` [PATCH 1/3] [gdb/tui] Keep inferior output in cmd window with ^L Tom de Vries
2023-05-31 13:35   ` Bruno Larsen
2023-05-31 14:19     ` Tom de Vries
2023-05-31 14:27       ` Bruno Larsen
2023-05-31 15:24         ` Tom de Vries
2023-05-31 15:27           ` Bruno Larsen
2023-05-31 23:37       ` Tom de Vries
2023-05-30 10:53 ` [PATCH 2/3] [gdb] Add observable terminal_owner_changed Tom de Vries
2023-05-30 10:53 ` [PATCH 3/3] [gdb/tui] Refresh on target_terminal_state::is_ours Tom de Vries
2023-05-31 14:18   ` Bruno Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230530105324.23089-1-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).