From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 59CEC3858D39 for ; Mon, 12 Jun 2023 10:28:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 59CEC3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686565726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F6vpuzxfJraDZBXV2iB5avdp880MDDfDT4md3wqIVrE=; b=fPV1o9wRKidEvdeEEDlfvmvQgndB4x+uC270c6PcVn5S1Qu0xQnW9O0EQ+vjHO4bxLjbW4 yxT5nnkGQJfux7jlLt7KLDRlaKBtJtJnb3wTQwU7wr8pWxBm6nTlMjv2RoNuY5wazl9Lcw czWCLJU7dw3qcnFbNvi6p4E5WmLE2HE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-407-Cfc-wQjiM5-qFmFq0x3_cg-1; Mon, 12 Jun 2023 06:28:43 -0400 X-MC-Unique: Cfc-wQjiM5-qFmFq0x3_cg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 824A0811E86; Mon, 12 Jun 2023 10:28:42 +0000 (UTC) Received: from fedora.redhat.com (unknown [10.45.224.85]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80AF611324; Mon, 12 Jun 2023 10:28:40 +0000 (UTC) From: Bruno Larsen To: gdb-patches@sourceware.org Cc: pedro@palves.net, aburgess@redhat.com, kevinb@redhat.com, brobecker@adacore.com, simon.marchi@polymtl.ca, tom@tromey.com, tdevries@suse.de, ulrich.weigand@de.ibm.com, eliz@gnu.org, Bruno Larsen Subject: [PATCH v2 0/1] update MAINTAINERS file with git trailers Date: Mon, 12 Jun 2023 12:01:38 +0200 Message-Id: <20230612100138.912813-1-blarsen@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Some private chats highlighted that the currently in use git trailers aren't explained well enough. This patch aims to fix that by adding the information in a more verbose way to guarantee that everyone is on the same page about them and refine anything that might still need work. The first version of this update didn't get much traction, so I decided to add every active global maintainer as CC, since everyone is affected by this and I want some consensus before comitting. Right now there is one big unanswered question: Should we have a specific tag to explicitly signal when a patch has been partially approved? Eli asked for it to avoid people mechanically reading tags from thinking that a patch has been fully approved when it was only partial. If we agree that there should be one, what would it look like? I suggested using Acked-By, but Simon uses it differently, and I opted to keep his usage of it. There is a secondary question for me, which is to add a hard requirement for approval tags. If we add it, the sourceware repository could have a pre-receive hook (or update hook) that automatically reject pushes if they dont have an approval tag. This would be especially useful to avoid accidentally pushing the wrong commit, but is more annoying for global maintainers (need to approve their own patches) and we'd need to see what to do about the obvious fix rule. My first answer for that is adding a special "Approved-By: Obvious fix" or similar. Thoughts? Comments? Suggestions? Version 1: https://inbox.sourceware.org/gdb-patches/20230516143826.3431583-1-blarsen@redhat.com/ Bruno Larsen (1): [gdb]: add git trailer information on gdb/MAINTAINERS gdb/MAINTAINERS | 56 ++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 48 insertions(+), 8 deletions(-) -- 2.40.1