From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id 89DC73858C53 for ; Wed, 14 Jun 2023 16:30:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89DC73858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-777b0cae9ecso380315139f.2 for ; Wed, 14 Jun 2023 09:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1686760248; x=1689352248; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YG1h370/tZQK7z+IuVDoccxW/pdjdmzeky7eHhRu3yo=; b=iXYCRN/1u4/pJe4f6RZv5bgiwvzg6fiAhsPlOKZ3njJm62nE3v9mViT9ALdnN55iTr VLDRZ8TRVMSR3mS+WNpDUiADXSsjkeCgNdPwnFU5exi5Vm+PsMdpLxGBEvIoEZ4xKKbV QiSP+a8fvQi66Z95IpGz0s4E6GCsAXqIPpKD7oPfhFlxTbgd5qEX0iHT2lUFVlDGKFhw /epGQw90NxdyUR2LgdbgDhNEC/swcrfxjbqDccLG0F9ZBeg2GkpTgv8jTK1IrHni62U8 OIutyf7jrnA/Da89NBLZ/Z6nULVwSzPbHKV16ECxXDIEXBh8rOoIPuZdDwjKZbIeE/XS t05w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686760248; x=1689352248; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YG1h370/tZQK7z+IuVDoccxW/pdjdmzeky7eHhRu3yo=; b=SX6738tfTHuoZGgRvuM1OpS1mHVRLKjQRMOEyMixOnozm2Q04N6+gtKPV6Odm/kxAm O0Mn69ik3tP0Ce9TJkP6pvKq7tAECgan+QGe9Xvh15UsEa5DD5sKkyL4jSZQ6tivCF43 0Sh3nY5don+X+NwdmuqtpOAKNkEWnqsJOhv6QMSusUeZOVN6Iz3Xu2GbEAi4vSKmimR+ AMz3Clh4+CcJT2EQqnNb4rGAzb+2VBemH8+R01sN/N7q3wwKOf0Vy2Jl2wt54loGCjLF ebL26pxN33Brb9iEXtfQQXfD83gAGCGCUtz8kBzQhoA53/SN5tFkgdgt3NTcHKLJ6Vco 5hTQ== X-Gm-Message-State: AC+VfDyTa9Gjsj/tEtwBlYAH1KBNmWf3A5SXyoeYeFOJ89ji1riEuD5a ZbmobOMcfU3LOvKzBVVx0dV3YDIOQma813x9uMZVvw== X-Google-Smtp-Source: ACHHUZ4DNXuyCkm0nlCb5icPOsVUV2Ib3IHzm0kCzmF55leJNmt6AuE/jWcakLhQCVaxEmfB7Ypqog== X-Received: by 2002:a05:6602:275c:b0:777:94ea:3658 with SMTP id b28-20020a056602275c00b0077794ea3658mr16023069ioe.5.1686760248681; Wed, 14 Jun 2023 09:30:48 -0700 (PDT) Received: from localhost.localdomain (75-166-136-83.hlrn.qwest.net. [75.166.136.83]) by smtp.gmail.com with ESMTPSA id t5-20020a028785000000b0040fa5258658sm5020983jai.77.2023.06.14.09.30.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 09:30:48 -0700 (PDT) From: Tom Tromey Date: Wed, 14 Jun 2023 10:30:47 -0600 Subject: [PATCH 1/5] Fix execute_frame_filters doc string MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230614-dap-frame-decor-v1-1-af87db6467b2@adacore.com> References: <20230614-dap-frame-decor-v1-0-af87db6467b2@adacore.com> In-Reply-To: <20230614-dap-frame-decor-v1-0-af87db6467b2@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.2 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When reading the doc string for execute_frame_filters, I wasn't sure if the ranges were inclusive or exclusive. This patch updates the doc string to reflect my findings, and also fixes an existing typo. --- gdb/python/lib/gdb/frames.py | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/gdb/python/lib/gdb/frames.py b/gdb/python/lib/gdb/frames.py index 5f8119c22a0..52f4191a8e8 100644 --- a/gdb/python/lib/gdb/frames.py +++ b/gdb/python/lib/gdb/frames.py @@ -165,18 +165,20 @@ def execute_frame_filters(frame, frame_low, frame_high): Arguments: frame: The initial frame. - frame_low: The low range of the slice. If this is a negative - integer then it indicates a backward slice (ie bt -4) which - counts backward from the last frame in the backtrace. + frame_low: The low range of the slice, counting from 0. If + this is a negative integer then it indicates a backward slice + (ie bt -4) which counts backward from the last frame in the + backtrace. - frame_high: The high range of the slice. If this is -1 then - it indicates all frames until the end of the stack from - frame_low. + frame_high: The high range of the slice, inclusive. If this + is -1 then it indicates all frames until the end of the stack + from frame_low. Returns: frame_iterator: The sliced iterator after all frame - filters have had a change to execute, or None if no frame + filters have had a chance to execute, or None if no frame filters are registered. + """ # Get a sorted list of frame filters. -- 2.40.1