From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by sourceware.org (Postfix) with ESMTPS id 361C93858D37 for ; Thu, 22 Jun 2023 16:19:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 361C93858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2a.google.com with SMTP id ca18e2360f4ac-780d166160fso21420639f.1 for ; Thu, 22 Jun 2023 09:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1687450768; x=1690042768; h=to:content-transfer-encoding:mime-version:message-id:date:subject :from:from:to:cc:subject:date:message-id:reply-to; bh=p4Ss6DAL2AQwwBXd65naqrI9mjrNkYzMjuu3W/0AwgI=; b=QVpWcprIG56IH5HXzBvTKI/AToGTXc49JYHDB48EI469VCF5b/wroMUjARcYXdTjrz 1pCXSNzWIWLIH7Edb7ARsJDES7HVWhAlBHgo0vok+soSUSU3iMgj4+itxlJ4GDOjVQL4 IOza737FQVW4BQpa90fwZrsj5AepiVzxEJ9Iiw19YDgTHVd8ZnfyRFnA1HsOFO55QqCX bgqKRTaa8cKPdIcpj0il2/aXQcz9UhVxczprO5sxNPVwZ37uvSfGmLmFj8jEjLfPS6av Yot1fjJteyxXK508OmuiWxGtP2eCRYKg7d+xb82/fUgrnS1lBmK9UhhzRvpJhzNLT0YR wp2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687450768; x=1690042768; h=to:content-transfer-encoding:mime-version:message-id:date:subject :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p4Ss6DAL2AQwwBXd65naqrI9mjrNkYzMjuu3W/0AwgI=; b=Fun7t38WERc9tusAIn/bvXu/ApoZ69AtMwYalVhzVvBWqlXHl7zWZcpdXv6C2j4sb2 5jmd8zgdjd43t+c72nwT6SH4dIBXeAcqnjBR+73Jjj+oP1xRKXZRGltwuRg7es+FHvfu s8ARV66v0YpdsvuxNhwTzYk8SBFVSnG7gydC+gh7snLF4OxdwTk8TxRPfQcmA4jNh9RI E5nGTWwYwZHAx6iWRVgBg5QwJGN8jsUwNkJtmHlkIp8H+2/f10o3BI8Ag/dJJvc8VTTV Jh6lybVFUMcGq1XUdbDqx4gcvXuvX2N3pVjK9ZeBnWUWE30o/6UXEBwK0sUCSN6h0TTT by/g== X-Gm-Message-State: AC+VfDxztNgNFFYlgpUKqUQoXjhK8Uj3IEirzIyEXRNHHP6HmLjq8atM kYDMudBux+YVE4Fg9bvQxbbeg3nMJ/STspTXKffUwQ== X-Google-Smtp-Source: ACHHUZ6qRfMPUUvrASjUCosO7wFmK/q60grUL78+/kO38+B7EnugnLjNq8PxqV4L4iOxQzFYzh9VSw== X-Received: by 2002:a6b:f915:0:b0:77e:3598:e511 with SMTP id j21-20020a6bf915000000b0077e3598e511mr15241185iog.2.1687450768436; Thu, 22 Jun 2023 09:19:28 -0700 (PDT) Received: from localhost.localdomain (75-166-136-83.hlrn.qwest.net. [75.166.136.83]) by smtp.gmail.com with ESMTPSA id y8-20020a6bd808000000b0077ac2261248sm2201987iob.5.2023.06.22.09.19.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 09:19:28 -0700 (PDT) From: Tom Tromey Subject: [PATCH v2 0/7] Reimplement DAP backtrace using frame filters Date: Thu, 22 Jun 2023 10:19:26 -0600 Message-Id: <20230614-dap-frame-decor-v2-0-10628dfa6b60@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAI50lGQC/3WNMQ6DMAxFr4Iy1xUEClWn3qNicGynZIAgB6FWi Ls3sHd8/+vpbSaJBknmUWxGZQ0pxCmDvRSGBpzeAoEzG1vaumyrBhhn8IqjAAtFhRsRcefrhrk 22XKYBJziRMPhjZgW0eOYVXz4nKlXn3kIaYn6Pctrdaz/I2sFJaC/d+zapu2cfSJjPuRKcTT9v u8/WTMsiMkAAAA= To: gdb-patches@sourceware.org X-Mailer: b4 0.12.2 X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This series reimplements DAP backtraces using frame filters. This seemed nice to have, because it would present users with a friendlier view into the stack. It also turned out to simplify the code a bit. --- Changes in v2: - Removed is_constant check from FrameVars - Added patch to strip typedefs - Added Ada scopes test case - Link to v1: https://inbox.sourceware.org/gdb-patches/20230614-dap-frame-decor-v1-0-af87db6467b2@adacore.com --- Tom Tromey (7): Fix execute_frame_filters doc string Add new interface to frame filter iteration Fix oversights in frame decorator code Simplify FrameVars Reimplement DAP stack traces using frame filters Handle typedefs in no-op pretty printers Add Ada scope test for DAP gdb/python/lib/gdb/FrameDecorator.py | 44 ++++++---------- gdb/python/lib/gdb/dap/bt.py | 81 +++++++++++++---------------- gdb/python/lib/gdb/dap/evaluate.py | 11 ++-- gdb/python/lib/gdb/dap/frames.py | 7 +++ gdb/python/lib/gdb/dap/scopes.py | 83 ++++++++++++------------------ gdb/python/lib/gdb/frames.py | 83 +++++++++++++++++++++--------- gdb/python/lib/gdb/printing.py | 23 +++++---- gdb/testsuite/gdb.dap/ada-scopes.exp | 84 +++++++++++++++++++++++++++++++ gdb/testsuite/gdb.dap/ada-scopes/pack.adb | 23 +++++++++ gdb/testsuite/gdb.dap/ada-scopes/pack.ads | 21 ++++++++ gdb/testsuite/gdb.dap/ada-scopes/prog.adb | 26 ++++++++++ gdb/testsuite/gdb.dap/scopes.c | 6 +-- 12 files changed, 321 insertions(+), 171 deletions(-) --- base-commit: d8a001f57016eff05977e9699c7aabdf4302c71b change-id: 20230614-dap-frame-decor-5cccd7f34dd3 Best regards, -- Tom Tromey