From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id C34B83858D3C for ; Thu, 22 Jun 2023 16:19:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C34B83858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-77e43dde8c9so178230439f.3 for ; Thu, 22 Jun 2023 09:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1687450769; x=1690042769; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YG1h370/tZQK7z+IuVDoccxW/pdjdmzeky7eHhRu3yo=; b=d1mwc3MV6Bq57owIXOoe6OAVdCDILkAsNxB2sFaAUT1hC2+mrjT9CnMpM9t1RmRuw+ /7CWGOCC+pyKXRNYdGhDcXpeEyXn+F0i4/BRIyKFCRVxxnzn4ZpoCdySoWPG5o+jmIdl +RckCFyelKN4JryS3r2L/HnuS7+xsvauUQDkziyQ7I8Hdd8BKH4f7e0XMtPgBfy4+kbY 7Oy8+rTW9CaQYsv9J4cM2ShXPIrOITp3s6cdUpOD6csddiqU8oztsnAjp9F7WDOZad02 F6aGi2ONMw7fbWZHRioKpw21vfec4j3kH6Jbbry2OlCx4dzZjuh+xGD7Kgy/coAYOw6R rGWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687450769; x=1690042769; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YG1h370/tZQK7z+IuVDoccxW/pdjdmzeky7eHhRu3yo=; b=FjE4h/UEvWrxoXuzCsQ/wqv/rHHAAof7mksT00bzO8euwh14Syc62lpr9Tt36WT5dD guKEPX4DKiWzoRdRiHhTNDQ12HOUy4n5PCXhoCRWn7qoEpM/HFcCfC1kQMCO4KbCanN0 YiIXUoCE5eBkaj287utZSeyxgn6h5op/j45nIKTg9dsd0URuAytzjvDfHMlpHqeTmL03 KqPuGlBKAmd/ekSMGTicuxTV0Z2zVkGlXmnMEK9TNS9WmKfZqEaamHhE9/62Hv8GYN1s RiAyMNACP53dTEa2xHNc0qfrpyLb6YmjiNRIBYdMHXhHTCy6sTATcUZXDhK7gsrgJvQo W3lA== X-Gm-Message-State: AC+VfDx2ElajguJog39+rP1Qhm3gk8bFuXIR2sW8UrpMXfnlHdqGoXlU I55Q99xbGyAFTeJl4hQWO/eDBQUvB5R4e+2DhA+rlw== X-Google-Smtp-Source: ACHHUZ5pMDY9Bcl5PCHiOx74WAGp8QKiFXf5s45Vu4pMFLHGP5p7qYeftmpRKAaWdDJwgYMf6jgkNg== X-Received: by 2002:a6b:6617:0:b0:776:f6cd:f68e with SMTP id a23-20020a6b6617000000b00776f6cdf68emr18781281ioc.1.1687450769027; Thu, 22 Jun 2023 09:19:29 -0700 (PDT) Received: from localhost.localdomain (75-166-136-83.hlrn.qwest.net. [75.166.136.83]) by smtp.gmail.com with ESMTPSA id y8-20020a6bd808000000b0077ac2261248sm2201987iob.5.2023.06.22.09.19.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jun 2023 09:19:28 -0700 (PDT) From: Tom Tromey Date: Thu, 22 Jun 2023 10:19:27 -0600 Subject: [PATCH v2 1/7] Fix execute_frame_filters doc string MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230614-dap-frame-decor-v2-1-10628dfa6b60@adacore.com> References: <20230614-dap-frame-decor-v2-0-10628dfa6b60@adacore.com> In-Reply-To: <20230614-dap-frame-decor-v2-0-10628dfa6b60@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.2 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When reading the doc string for execute_frame_filters, I wasn't sure if the ranges were inclusive or exclusive. This patch updates the doc string to reflect my findings, and also fixes an existing typo. --- gdb/python/lib/gdb/frames.py | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/gdb/python/lib/gdb/frames.py b/gdb/python/lib/gdb/frames.py index 5f8119c22a0..52f4191a8e8 100644 --- a/gdb/python/lib/gdb/frames.py +++ b/gdb/python/lib/gdb/frames.py @@ -165,18 +165,20 @@ def execute_frame_filters(frame, frame_low, frame_high): Arguments: frame: The initial frame. - frame_low: The low range of the slice. If this is a negative - integer then it indicates a backward slice (ie bt -4) which - counts backward from the last frame in the backtrace. + frame_low: The low range of the slice, counting from 0. If + this is a negative integer then it indicates a backward slice + (ie bt -4) which counts backward from the last frame in the + backtrace. - frame_high: The high range of the slice. If this is -1 then - it indicates all frames until the end of the stack from - frame_low. + frame_high: The high range of the slice, inclusive. If this + is -1 then it indicates all frames until the end of the stack + from frame_low. Returns: frame_iterator: The sliced iterator after all frame - filters have had a change to execute, or None if no frame + filters have had a chance to execute, or None if no frame filters are registered. + """ # Get a sorted list of frame filters. -- 2.40.1