From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 712753858C41 for ; Tue, 20 Jun 2023 17:36:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 712753858C41 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id C915B1003B6CE for ; Tue, 20 Jun 2023 17:36:39 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id BfHTqsuqp0JMxBfHTqz1sj; Tue, 20 Jun 2023 17:36:39 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=BMF2EHcG c=1 sm=1 tr=0 ts=6491e3a7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=of4jigFt-DYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=8Ne5uJgdj88z-JG2tdEA:9 a=QEXdDO2ut3YA:10:nop_charset_2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gYrx9pXniMsmvs+xnrI6TflkoPHuioun14snJT7NejU=; b=cGq+Lk0jXoxEJVc8xdM0Le6XBu B7P6R7lwOuG6QYdgJc36d/CNn7nhVCYMraJY6FW+UVOSyyU6mFwwS0WmUWLB33gRkVVEAm0gTo9dX bqw9m4T84vm3/e01WfWvicHh8; Received: from 75-166-136-83.hlrn.qwest.net ([75.166.136.83]:54256 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qBfHT-001PQG-Li for gdb-patches@sourceware.org; Tue, 20 Jun 2023 11:36:39 -0600 From: Tom Tromey Date: Tue, 20 Jun 2023 11:36:40 -0600 Subject: [PATCH v2 4/8] Simplify agent_expr constructor MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230619-ax-new-v2-4-47638d750dd7@tromey.com> References: <20230619-ax-new-v2-0-47638d750dd7@tromey.com> In-Reply-To: <20230619-ax-new-v2-0-47638d750dd7@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.136.83 X-Source-L: No X-Exim-ID: 1qBfHT-001PQG-Li X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-136-83.hlrn.qwest.net ([192.168.0.21]) [75.166.136.83]:54256 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This simplifies the agent_expr constructor a bit, and removes the destructor entirely. --- gdb/ax-general.c | 13 ------------- gdb/ax.h | 10 ++++++---- 2 files changed, 6 insertions(+), 17 deletions(-) diff --git a/gdb/ax-general.c b/gdb/ax-general.c index e2a3c31e7f4..b28c8e70e0c 100644 --- a/gdb/ax-general.c +++ b/gdb/ax-general.c @@ -36,19 +36,6 @@ static void generic_ext (struct agent_expr *x, enum agent_op op, int n); /* Functions for building expressions. */ -agent_expr::agent_expr (struct gdbarch *gdbarch, CORE_ADDR scope) -{ - this->gdbarch = gdbarch; - this->scope = scope; - - this->tracing = 0; - this->trace_string = 0; -} - -agent_expr::~agent_expr () -{ -} - /* Append the low N bytes of VAL as an N-byte integer to the expression X, in big-endian order. */ static void diff --git a/gdb/ax.h b/gdb/ax.h index b0eb20daf75..67ad3145349 100644 --- a/gdb/ax.h +++ b/gdb/ax.h @@ -81,9 +81,11 @@ enum agent_flaws struct agent_expr { /* Construct an empty agent expression. */ - explicit agent_expr (struct gdbarch *gdbarch, CORE_ADDR scope); - - ~agent_expr (); + agent_expr (struct gdbarch *gdbarch, CORE_ADDR scope) + : gdbarch (gdbarch), + scope (scope), + tracing (0) + { } /* The bytes of the expression. */ gdb::byte_vector buf; @@ -139,7 +141,7 @@ struct agent_expr tracenz bytecode to record nonzero bytes, up to a length that is the value of trace_string. */ - int trace_string; + int trace_string = 0; }; /* An agent_expr owning pointer. */ -- 2.39.2