From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 8AB923858C54 for ; Tue, 20 Jun 2023 17:36:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8AB923858C54 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id EA3E81003B6D3 for ; Tue, 20 Jun 2023 17:36:39 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id BfHTqNRTjEJzCBfHTq4Qs4; Tue, 20 Jun 2023 17:36:39 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=As4rYMxP c=1 sm=1 tr=0 ts=6491e3a7 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10:nop_charset_1 a=of4jigFt-DYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=yCrJt_9xozPtFWDtubIA:9 a=QEXdDO2ut3YA:10:nop_charset_2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gpar/7PdV80i5AnQ0pK/Kb3TJMfiPIiGwnoemuqhsLE=; b=vG4KbsisUi0lxH0nYSGcZrpj0Q flW6d/aS5SfDaMUNo6gdQnP4PwFfaK7SBUzngLgwFnMMkIjtbFG7P9gBnHYokmby2NfzvIbsshwNR PJsp2J7s46i3fJM8/3JWv/FSv; Received: from 75-166-136-83.hlrn.qwest.net ([75.166.136.83]:54256 helo=[192.168.0.21]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qBfHT-001PQG-Pr for gdb-patches@sourceware.org; Tue, 20 Jun 2023 11:36:39 -0600 From: Tom Tromey Date: Tue, 20 Jun 2023 11:36:41 -0600 Subject: [PATCH v2 5/8] Use bool for agent_expr::tracing MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230619-ax-new-v2-5-47638d750dd7@tromey.com> References: <20230619-ax-new-v2-0-47638d750dd7@tromey.com> In-Reply-To: <20230619-ax-new-v2-0-47638d750dd7@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.2 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.136.83 X-Source-L: No X-Exim-ID: 1qBfHT-001PQG-Pr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-136-83.hlrn.qwest.net ([192.168.0.21]) [75.166.136.83]:54256 X-Source-Auth: tom+tromey.com X-Email-Count: 14 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This changese agent_expr::tracing to have type bool, allowing inline initialization and cleaning up the code a little. --- gdb/ax-gdb.c | 10 +++++----- gdb/ax.h | 7 +++---- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/gdb/ax-gdb.c b/gdb/ax-gdb.c index b0bde62f465..55450bd2979 100644 --- a/gdb/ax-gdb.c +++ b/gdb/ax-gdb.c @@ -2335,7 +2335,7 @@ gen_trace_for_var (CORE_ADDR scope, struct gdbarch *gdbarch, agent_expr_up ax (new agent_expr (gdbarch, scope)); struct axs_value value; - ax->tracing = 1; + ax->tracing = true; ax->trace_string = trace_string; gen_var_ref (ax.get (), &value, var); @@ -2368,7 +2368,7 @@ gen_trace_for_expr (CORE_ADDR scope, struct expression *expr, agent_expr_up ax (new agent_expr (expr->gdbarch, scope)); struct axs_value value; - ax->tracing = 1; + ax->tracing = true; ax->trace_string = trace_string; value.optimized_out = 0; expr->op->generate_ax (expr, ax.get (), &value); @@ -2395,7 +2395,7 @@ gen_eval_for_expr (CORE_ADDR scope, struct expression *expr) agent_expr_up ax (new agent_expr (expr->gdbarch, scope)); struct axs_value value; - ax->tracing = 0; + ax->tracing = false; value.optimized_out = 0; expr->op->generate_ax (expr, ax.get (), &value); @@ -2414,7 +2414,7 @@ gen_trace_for_return_address (CORE_ADDR scope, struct gdbarch *gdbarch, agent_expr_up ax (new agent_expr (gdbarch, scope)); struct axs_value value; - ax->tracing = 1; + ax->tracing = true; ax->trace_string = trace_string; gdbarch_gen_return_address (gdbarch, ax.get (), &value, scope); @@ -2443,7 +2443,7 @@ gen_printf (CORE_ADDR scope, struct gdbarch *gdbarch, int tem; /* We're computing values, not doing side effects. */ - ax->tracing = 0; + ax->tracing = false; /* Evaluate and push the args on the stack in reverse order, for simplicity of collecting them on the target side. */ diff --git a/gdb/ax.h b/gdb/ax.h index 67ad3145349..0e82ed9e313 100644 --- a/gdb/ax.h +++ b/gdb/ax.h @@ -83,8 +83,7 @@ struct agent_expr /* Construct an empty agent expression. */ agent_expr (struct gdbarch *gdbarch, CORE_ADDR scope) : gdbarch (gdbarch), - scope (scope), - tracing (0) + scope (scope) { } /* The bytes of the expression. */ @@ -132,10 +131,10 @@ struct agent_expr be available when the user later tries to evaluate the expression in GDB. - Setting the flag 'tracing' to non-zero enables the code that + Setting the flag 'tracing' to true enables the code that emits the trace bytecodes at the appropriate points. */ - unsigned int tracing : 1; + bool tracing = false; /* This indicates that pointers to chars should get an added tracenz bytecode to record nonzero bytes, up to a length that -- 2.39.2