From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 460A73858D28 for ; Wed, 21 Jun 2023 23:14:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 460A73858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35LNBVt8014997; Wed, 21 Jun 2023 23:14:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=dqUe8bDu6rGYlQOx5bdkmFW6u2MkysW3FPVqrdLOeQs=; b=R/VFg6SpU4xYzEtS278wuSLk7OLXrEhdzQgVkvuJ9GFk+MVE1gcx4ULC4V2gWEGe/6cI mIm4gOIHpB9Wg55u3hvgCO4aFA29h+z+oc6prnGDI84rMI+9rXsef1QyZn6PYOUPDq8E mukFQC6hzXu7imI/cyqWOzUfvRX83FWpfqGyglTIyHGDhgQ13Jo6nHvjUuAuDbFTu0/T 82kLKnv7R2VUeZMRMhvXwU95vi9vI4EYJqgJoTiV/FrB/vmSdDsXtfLRV/TtH6HBou3g thqyo3bis45w8Iijo1jbBH0bBdCkqP6PUK8IodEqL+jqWE7XAY2WfDMn/RsiDrbjAL2U /Q== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rcaasggfb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Jun 2023 23:14:36 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 35LMLZmr011800; Wed, 21 Jun 2023 23:14:34 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3r94f534yv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Jun 2023 23:14:34 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 35LNEVGQ20185738 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 Jun 2023 23:14:31 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3107720043; Wed, 21 Jun 2023 23:14:31 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E0C1820040; Wed, 21 Jun 2023 23:14:30 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.179.1.208]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 21 Jun 2023 23:14:30 +0000 (GMT) From: Ilya Leoshkevich To: Tom Tromey Cc: gdb-patches@sourceware.org, Ilya Leoshkevich Subject: [PATCH] gdb: Fix "target file /proc/.../cmdline contained unexpected null characters" Date: Thu, 22 Jun 2023 01:14:25 +0200 Message-Id: <20230621231425.3972673-1-iii@linux.ibm.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: dwEmUFD-y6oqyI7Z1r3CK7NsqxeSvpju X-Proofpoint-GUID: dwEmUFD-y6oqyI7Z1r3CK7NsqxeSvpju X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-21_12,2023-06-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 phishscore=0 mlxscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306210193 X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: cmdline is read with target_fileio_read_stralloc(), which warns on seeing null characters. However, it's perfectly valid for cmdline to contain \0s, so switch to target_fileio_read_alloc(). --- gdb/linux-tdep.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c index b5eee5e108c..96cbe8e5520 100644 --- a/gdb/linux-tdep.c +++ b/gdb/linux-tdep.c @@ -1902,15 +1902,22 @@ linux_fill_prpsinfo (struct elf_internal_linux_prpsinfo *p) pid = inferior_ptid.pid (); xsnprintf (filename, sizeof (filename), "/proc/%d/cmdline", (int) pid); /* The full name of the program which generated the corefile. */ - gdb::unique_xmalloc_ptr fname - = target_fileio_read_stralloc (NULL, filename); + gdb_byte *buf = NULL; + size_t buf_len = target_fileio_read_alloc (NULL, filename, &buf); + gdb::unique_xmalloc_ptr fname ((char *)buf); - if (fname == NULL || fname.get ()[0] == '\0') + if (buf_len < 1 || fname.get ()[0] == '\0') { /* No program name was read, so we won't be able to retrieve more information about the process. */ return 0; } + if (fname.get ()[buf_len - 1] != '\0') + { + warning (_("target file %s " + "does not contain a trailing null character"), + filename); + } memset (p, 0, sizeof (*p)); -- 2.40.1