From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 059A03884504 for ; Fri, 30 Jun 2023 21:07:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 059A03884504 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688159253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4VUE9ctwv2tkt9RcQDFSgb+r0F/ZxCjt2Eh+r7aAWuY=; b=KlIFhFKl0VR8tujMZ5WEhrzxDemx8nU1Yi8RTaEVv1DSKLbTbnFaiGJTz/VMKw0jQwJVZq hYarFnVjzLF/iCiEp2lKOSyKCen9mKL3AcDZb8BllxPHbEnmcJGuoz+Z8F9tyaPyK6xajh Su7KUhqSPzdslvSkoqloTW72rHu5XJs= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-160-hSHcIW56OGeY8KCihsD3Vg-1; Fri, 30 Jun 2023 17:07:29 -0400 X-MC-Unique: hSHcIW56OGeY8KCihsD3Vg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 04219873234; Fri, 30 Jun 2023 21:07:29 +0000 (UTC) Received: from f38-zws-nv (unknown [10.22.9.124]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DDACF2166B2D; Fri, 30 Jun 2023 21:07:27 +0000 (UTC) Date: Fri, 30 Jun 2023 14:07:26 -0700 From: Kevin Buettner To: Bruno Larsen Cc: gdb-patches@sourceware.org, pedro@palves.net, aburgess@redhat.com, brobecker@adacore.com, simon.marchi@polymtl.ca, tom@tromey.com, tdevries@suse.de, ulrich.weigand@de.ibm.com, eliz@gnu.org Subject: Re: [PATCH v3 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS Message-ID: <20230630140726.292b6eed@f38-zws-nv> In-Reply-To: <20230628124205.1604307-3-blarsen@redhat.com> References: <20230628124205.1604307-2-blarsen@redhat.com> <20230628124205.1604307-3-blarsen@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_FILL_THIS_FORM_SHORT,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, See my comments in-line below. Kevin On Wed, 28 Jun 2023 14:42:06 +0200 Bruno Larsen wrote: > The project has been using Tested-By (tb), Reviewed-By (rb) and > Approved-By (ab) for some time, but there has been no information to be > found in the actual repository. This commit changes that by adding > information about all git trailers to the MAINTAINERS file, so that it > can be easily double-checked. > > The upstream discussion also brought up the use of Acked-by, which is > better defined in this commit. Finally, for completeness sake, the > trailers Co-Authored-By and Bug were added, even though they have been > in use for some time already > --- > gdb/MAINTAINERS | 66 +++++++++++++++++++++++++++++++++++++++++++------ > 1 file changed, 58 insertions(+), 8 deletions(-) > > diff --git a/gdb/MAINTAINERS b/gdb/MAINTAINERS > index 7fa608fd82c..cd9d299ea42 100644 > --- a/gdb/MAINTAINERS > +++ b/gdb/MAINTAINERS > @@ -43,14 +43,9 @@ patch without review from another maintainer. This especially includes > patches which change internal interfaces (e.g. global functions, data > structures) or external interfaces (e.g. user, remote, MI, et cetera). > > -The term "review" is used in this file to describe several kinds of feedback > -from a maintainer: approval, rejection, and requests for changes or > -clarification with the intention of approving a revised version. Review is > -a privilege and/or responsibility of various positions among the GDB > -Maintainers. Of course, anyone - whether they hold a position but not the > -relevant one for a particular patch, or are just following along on the > -mailing lists for fun, or anything in between - may suggest changes or > -ask questions about a patch! > +The word "contributor" is used in this document to refer to any GDB > +developer listed above as well as folks who may have suggested some > +patches but aren't part of one of those categories for any reason. > > There's also a couple of other people who play special roles in the GDB > community, separately from the patch process: > @@ -78,6 +73,61 @@ consensus among the global maintainers and any other involved parties. > In cases where consensus can not be reached, the global maintainers may > ask the official FSF-appointed GDB maintainers for a final decision. > > +The term "review" is used in this file to describe several kinds of > +feedback from a maintainer: approval, rejection, and requests for changes > +or clarification with the intention of approving a revised version. > +Approval is a privilege and/or responsibility of various positions among > +the GDB Maintainers. Of course, anyone - whether they hold a position, but > +not the relevant one for a particular patch, or are just following along on > +the mailing lists for fun, or anything in between - may suggest changes, ask > +questions about a patch or say if they believe a patch is fit for upstreaming! > + > +To ensure that patches are only pushed when approved, and to properly credit > +the contributors who take the time to improve this project, the following > +trailers are used to identify who contributed and how. All patches pushed > +upstream should have at least one Approved-By patches (with the exception of > +obvious patches, see below). The trailers (or tags) currently in use are: > + > + - Acked-By: > + > + Used when a contributor has taken a quick glance at a patch and agrees > + with the direction outlined in the commit message, but hasn't evaluated > + the code for correctness or regressions. > + > + - Tested-by: > + > + Used when a contributor has tested the patch and finds that it > + fixes the claimed problem. It may also be used to indicate that > + the contributor has performed regression testing. By itself, this > + tag says nothing about the quality of the fix implemented by the > + patch. > + > + - Reviewed-by: > + > + Used when a contributor has looked at code and agrees with the s/code/the code/ > + changes, but either doesn't have the authority or doesn't feel > + comfortable approving the patch. > + > + - Approved-by: > + > + Used by responsible maintainers or global maintainers when a patch is > + ready to be upstreamed. Some patches may touch multiple areas and > + require multiple approvals before landing (such as a maintainer only > + approving documentation), it is up to the maintainer giving the approval > + tag to make it clear when that a tag is not sufficient. Responsible, > + Global and Official FSF-appointed maintainers may approve their own > + patches, but it is recommended that they seek external approval before > + doing so. > + > + - Co-Authored-By: > + > + Used when the commit includes meaningful conrtibutions from multiple people. For all of the above trailers/tags, I think it's worth mentioning what should follow the ":". As I understand it, the name and email address should be specified - like this: Approved-by: Jane Doe > + > + - Bug: > + > + This trailer is added with a link to the GDB bug tracker for added context Maybe s/GDB bug tracker/GDB bug tracker bug/ ? I.e. we want to specify a link to a specific bug, not a link to the top level for the bug tracking site. > + on relevant commits. > + > > The Obvious Fix Rule > -------------------- > -- > 2.41.0 >