From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by sourceware.org (Postfix) with ESMTPS id 0EADF3858C5E for ; Mon, 10 Jul 2023 22:56:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0EADF3858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689029820; x=1720565820; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=PATCYiECkejEftEPCylsE9tQOafrljzkHscIog1c3qc=; b=LXMcqKBjVmoPWqVLrtEbRmN7fI0piQxi7cbQsVjGjqGSKDYVvyi7VA+p /COHAQVY2Sp5nNqLmj652HL5bSmvatbzOLANDW/+yrHJj8uCBYXG3yjUn XF9zJvyxc3Lgr746loM6disLr3qFp/3Zw/66e3s6ylADO6d3NZsFzBjh8 c0dFPJjUGFikROWrDqaGHx/tJ+hCqEqaWte8cE5MTtGBaeHDQL/xCWMAj tqnQ8wGCFutGeVvByS6bdNndxBNwzYzsUkVlvIC5lSOl+Ge5lS/OGsZtv dx+p/6TqSoqcZMYPe2KNFKm1K2hssp1bTbodOukwU9JpI995Z5iJ/kKjE Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="361940133" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="361940133" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 15:56:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="756144145" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="756144145" Received: from skurzyno-mobl.ger.corp.intel.com (HELO localhost) ([10.252.44.160]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 15:56:54 -0700 From: Abdul Basit Ijaz To: gdb-patches@sourceware.org Cc: abdul.b.ijaz@intel.com, JiniSusan.George@amd.com, tom@tromey.com, eliz@gnu.org Subject: [PATCH v3 0/4] GDB support for DW_AT_trampoline Date: Tue, 11 Jul 2023 00:56:39 +0200 Message-Id: <20230710225643.32280-1-abdul.b.ijaz@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: "Ijaz, Abdul B" Hi, please find attached a series of patches that attempts to enable GDB to handle the DW_AT_trampoline attribute on functions and inlined functions. DW_AT_trampoline can be emitted by the compiler for functions that are compiler generated trampolines (e.g. wrapping other function calls). In doing so, the compiler can specify a target as the value of DW_AT_trampoline which the trampoline is wrapping. This series enables GDB to recognize the DW_AT_trampoline and store the target for a given function. Patch 3 adapts GDB's stepping behavior when dealing with trampolines and attempts to - by default - hide these trampolines from the user. When about to step into a trampoline, instead, GDB will try and step through the trampoline and directly towards the target. Patch 4 in V2 now skip trampoline frames in the stack for printing or finish command. A new setting has been introduced to turn off this modified stepping behavior or printing of stack for trampolines. The motivation for these patches comes from ifx which emits the attribute for some of its compiler generated functions. As I do not know of any other compiler (especially gcc/gfortran) emitting DW_AT_trampoline, I added a gdb.dwarf2 test to this series in order to test the trampoline handling within GDB. Changes since V2: * Mention "on" as default value for skip-trampoline-functions in NEWS and gdb.textinfo according to the latest feedback. * Update copyright years from 2022 to 2023 in test files which are newly added. V2 series of patches can be found here: https://sourceware.org/pipermail/gdb-patches/2023-June/200066.html No regression seen on testing x64/x86/gdbserver test configurations for these changes using Ubuntu 22. Abdul Basit Ijaz (1): gdb: Skip trampoline frames in the stack for printing or finish command. Nils-Christian Kempke (3): gdb, dwarf: add support for DW_AT_trampoline in DWARF reader gdb/symtab: add lookup for trampoline functions gdb/infrun: handle stepping through functions with DW_AT_trampoline gdb/NEWS | 15 ++ gdb/doc/gdb.texinfo | 47 ++++ gdb/dwarf2/read.c | 45 +++- gdb/gdbtypes.c | 35 ++- gdb/gdbtypes.h | 103 +++++++- gdb/infcmd.c | 13 + gdb/infrun.c | 81 +++++- gdb/infrun.h | 10 + gdb/stack.c | 8 + gdb/symtab.c | 80 ++++++ gdb/symtab.h | 19 ++ .../gdb.dwarf2/dw2-function-trampolines.c | 80 ++++++ .../gdb.dwarf2/dw2-function-trampolines.exp | 245 ++++++++++++++++++ gdb/testsuite/gdb.fortran/func-trampoline.exp | 69 +++++ gdb/testsuite/gdb.fortran/func-trampoline.f90 | 39 +++ .../gdb.fortran/mixed-lang-stack.exp | 10 +- 16 files changed, 885 insertions(+), 14 deletions(-) create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-function-trampolines.c create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-function-trampolines.exp create mode 100644 gdb/testsuite/gdb.fortran/func-trampoline.exp create mode 100644 gdb/testsuite/gdb.fortran/func-trampoline.f90 -- 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928