From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Tom Tromey <tom@tromey.com>, Bruno Larsen <blarsen@redhat.com>
Cc: gdb-patches@sourceware.org, Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH v2] gdb: Fix "target file /proc/.../cmdline contained unexpected null characters"
Date: Wed, 19 Jul 2023 13:27:45 +0200 [thread overview]
Message-ID: <20230719112909.1843509-1-iii@linux.ibm.com> (raw)
When using the gcore command, GDB prints the following warning:
(gdb) gcore
warning: target file /proc/.../cmdline contained unexpected null characters
The reason is that cmdline is read with target_fileio_read_stralloc(),
which warns on seeing null characters. However, it's perfectly valid
for cmdline to contain \0s, so switch to target_fileio_read_alloc().
---
v1: https://sourceware.org/pipermail/gdb-patches/2023-June/200436.html
https://sourceware.org/pipermail/gdb-patches/2023-July/200993.html
v1 -> v2: Improve the commit message (Bruno).
Handle the missing trailing '\0' (Bruno).
gdb/linux-tdep.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
index b5eee5e108c..90ad02310b3 100644
--- a/gdb/linux-tdep.c
+++ b/gdb/linux-tdep.c
@@ -1902,15 +1902,23 @@ linux_fill_prpsinfo (struct elf_internal_linux_prpsinfo *p)
pid = inferior_ptid.pid ();
xsnprintf (filename, sizeof (filename), "/proc/%d/cmdline", (int) pid);
/* The full name of the program which generated the corefile. */
- gdb::unique_xmalloc_ptr<char> fname
- = target_fileio_read_stralloc (NULL, filename);
+ gdb_byte *buf = NULL;
+ size_t buf_len = target_fileio_read_alloc (NULL, filename, &buf);
+ gdb::unique_xmalloc_ptr<char> fname ((char *)buf);
- if (fname == NULL || fname.get ()[0] == '\0')
+ if (buf_len < 1 || fname.get ()[0] == '\0')
{
/* No program name was read, so we won't be able to retrieve more
information about the process. */
return 0;
}
+ if (fname.get ()[buf_len - 1] != '\0')
+ {
+ warning (_("target file %s "
+ "does not contain a trailing null character"),
+ filename);
+ return 0;
+ }
memset (p, 0, sizeof (*p));
--
2.41.0
next reply other threads:[~2023-07-19 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 11:27 Ilya Leoshkevich [this message]
2023-07-19 16:07 ` Bruno Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230719112909.1843509-1-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).