From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [pushed 2/2] [gdb/testsuite] Improve gdb.arch/arm-pthread_cond_timedwait-bt.exp
Date: Sat, 22 Jul 2023 11:00:44 +0200 [thread overview]
Message-ID: <20230722090044.18503-2-tdevries@suse.de> (raw)
In-Reply-To: <20230722090044.18503-1-tdevries@suse.de>
I noticed in test-case gdb.arch/arm-pthread_cond_timedwait-bt.exp that
prepare_for_testing is used, followed by a clean_restart.
This calls clean_restart twice in a row.
Fix this by using build_executable instead.
Also, I noticed that the test-case requires an SVC instruction, so add a
require to limit the test-case to supported architectures.
While we're at it, run M-x indent-region in emacs to fix indentation.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp b/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
index 17f8d68b847..e64fa46ef4f 100644
--- a/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
+++ b/gdb/testsuite/gdb.arch/arm-pthread_cond_timedwait-bt.exp
@@ -17,21 +17,24 @@
# syscall is active. But some active syscalls keep PC pointing to the SVC
# instruction itself.
+# Require an architecture with the SVC instruction.
+require {is_any_target "aarch64*-*-*" "arm*-*-*"}
+
# See if we have target board readnow.exp or similar. We're using
# --readnever, which is not allowed in combination with --readnow.
require !readnow
standard_testfile
-if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} \
- {debug pthreads}] } {
+if { [build_executable "failed to prepare" ${testfile} ${srcfile} \
+ {debug pthreads}] } {
return
}
save_vars { GDBFLAGS } {
append GDBFLAGS " --readnever"
if { [clean_restart ${binfile}] == -1 } {
- return -1
+ return -1
}
}
--
2.35.3
prev parent reply other threads:[~2023-07-22 9:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-22 9:00 [pushed 1/2] [gdb/testsuite] Use proc readnow in two test-cases Tom de Vries
2023-07-22 9:00 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230722090044.18503-2-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).