From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=fAkn=DR=lancelotsix.com=lsix@sourceware.org>
Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111])
	by sourceware.org (Postfix) with ESMTPS id 9E12D3858C53
	for <gdb-patches@sourceware.org>; Mon, 31 Jul 2023 14:36:52 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9E12D3858C53
Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com
Received: from octopus (unknown [IPv6:2a02:390:9086:0:e1fd:bb76:ac43:b119])
	by lndn.lancelotsix.com (Postfix) with ESMTPSA id 0DEC580AB2;
	Mon, 31 Jul 2023 14:36:51 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com;
	s=2021; t=1690814211;
	bh=UO3qk5NYneZjXjXeADpY7Vhy5B7kRKHPrSqG4MPhnYA=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=QmNOXwWfswiLdKulRPj5ZGgVKZ/RML3nVJycLvmtPtnFl8pNkrqb1fmbz2narvsaV
	 NJZ1N5oA8E8ecxQ0KZnMPpd8IOZ6lBqAlkTwpEwuUOPMhvD2Y4/yxfGZnwO1vpN2eM
	 0p494ZcR+pI4iMilzZrA+ku7mlvd/1zPoXAPRpw9GZ8paZXQsY4fkUC7itG8rD2AS0
	 wFZMyaRA84ozuI2rhlfLqHRu/NkJPkxPukBvk7IcV/TC2J27rqWB9kDExR5ASJntZj
	 wRlwFVW6fJszCQ4IPowS7lukvrljbnDttwvbLS5EyGoNh6DjSLdrsNvPGx4ZvoQfLh
	 4q4zhApGYQ4Rg==
Date: Mon, 31 Jul 2023 15:36:24 +0100
From: Lancelot SIX <lsix@lancelotsix.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/6] Rename private member of FrameDecorator
Message-ID: <20230731143624.f53cvywa6niuq7k5@octopus>
References: <20230725-dap-bt-path-v1-0-bb015b0d8e54@adacore.com>
 <20230725-dap-bt-path-v1-1-bb015b0d8e54@adacore.com>
 <20230728145046.waxsfe2w2yhklkfa@octopus>
 <87cz08gnma.fsf@tromey.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87cz08gnma.fsf@tromey.com>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Mon, 31 Jul 2023 14:36:51 +0000 (UTC)
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On Mon, Jul 31, 2023 at 08:30:05AM -0600, Tom Tromey wrote:
> >>>>> "Lancelot" == Lancelot SIX <lsix@lancelotsix.com> writes:
> 
> Lancelot> I do not object to this change, I am just noting that nothing is really
> Lancelot> private in Python, and it seems to me that the commit message promises
> Lancelot> otherwise.
> 
> I've reworded it to:
> 
>     In Python, a member name starting with "__" is specially handled to
>     make it "more private" to the class -- it isn't truly private, but it
>     is renamed to make it less likely to be reused by mistake.
> 
> Tom

Hi,

FWIW, this looks good to me.

Best,
Lancelot.