From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [IPv6:2001:67c:2050:0:465::201]) by sourceware.org (Postfix) with ESMTPS id C52ED3858025; Mon, 7 Aug 2023 11:19:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C52ED3858025 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4RKDP01ZXvz9sS2; Mon, 7 Aug 2023 13:19:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1691407172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lk2U3DqVbCodm5o9LuS9JVZh/KH21DTvzeWyBdIAqdE=; b=VDU//kvmov7i7P9TRvcdJYtah5EFgHDO4PooDfZMNguB7JQudcH+clKKrrUacjxYN55rif HZbnCZohYO7OOZrSkMPBExeT/7IZB8an/MvHGFMgu1XsW/tDX+5SoQX8MwEkIdT1LYwM1E g07Bv/0lc8sGzg1fL1zmZwckF/W1dlK4hPOyH4J8bC7dzxnMe1mXX90XUQlBwM7qSvVgVZ fbCywS/przIUUReBhPh2Xp/9V7M0JcRhNz7+Kjm2SVH03tyf/VP7ZZD/C//4arIwe0qrlq Q3PTCxedR2iQzMqQOy2krQjtkpB1J9fBBSK7/wPDJClkHo9GZk6agRN9sZ1HWg== From: =?UTF-8?q?Arsen=20Arsenovi=C4=87?= To: gdb-patches@sourceware.org, binutils@sourceware.org Cc: Iain Sandoe Subject: [PATCH 20/45] Darwin, config: Revise host config fragment. Date: Mon, 7 Aug 2023 13:07:23 +0200 Message-ID: <20230807111029.2320238-21-arsen@aarsen.me> In-Reply-To: <20230807111029.2320238-1-arsen@aarsen.me> References: <20230807111029.2320238-1-arsen@aarsen.me> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Iain Sandoe There were two uses for the Darwin host config fragment: The first is to arrange for targets that support mdynamic-no-pic to be built with that enabled (since it makes a significant difference to the compiler performance). We can be more specific in the application of this, since it only applies to 32b hosts plus powerpc64-darwin9. The second was to work around a tool bug where -fno-PIE was not propagated to the link stage. This second use is redundant, since the buggy toolchain cannot bootstrap current GCC sources anyway. This makes the host fragment more specific and reduces the number of toolchains for which it is included which reduces clutter in configure lines. Signed-off-by: Iain Sandoe config/ChangeLog: * mh-darwin: Make this specific to handling the mdynamic-no-pic case. ChangeLog: * configure: Regenerate. * configure.ac: Adjust cases for which it is necessary to include the Darwin host config fragment. --- config/mh-darwin | 57 ++++++++++++++++++++++++++++-------------------- 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/config/mh-darwin b/config/mh-darwin index 148b73038c3..fb2bb5ad1d9 100644 --- a/config/mh-darwin +++ b/config/mh-darwin @@ -1,29 +1,38 @@ # The -mdynamic-no-pic ensures that the compiler executable is built without -# position-independent-code -- the usual default on Darwin. This fix speeds -# compiles by 3-5%. Don't add it if the compiler doesn't also support -# -mno-dynamic-no-pic to undo it. -DARWIN_MDYNAMIC_NO_PIC := \ -`case ${host} in i?86-*-darwin* | powerpc-*-darwin*) \ - $(CC) -S -xc /dev/null -o /dev/null -mno-dynamic-no-pic 2>/dev/null \ - && echo -mdynamic-no-pic ;; esac` -DARWIN_GCC_MDYNAMIC_NO_PIC := \ -`case ${host} in i?86-*-darwin* | powerpc-*-darwin*) \ - $(CC) -S -xc /dev/null -o /dev/null -mno-dynamic-no-pic 2>/dev/null \ - || echo -mdynamic-no-pic ;; esac` +# position-independent-code -- the usual default on Darwin. This speeds compiles +# by 8-20% (measurements made against GCC-11). +# However, we cannot add it unless the bootstrap compiler supports +# -mno-dynamic-no-pic to undo it, since libiberty, at least, needs this. -# ld on Darwin versions >= 10.7 defaults to PIE executables. Disable this for -# gcc components, since it is incompatible with our pch implementation. -DARWIN_NO_PIE := `case ${host} in *-*-darwin[1][1-9]*) echo -Wl,-no_pie ;; esac;` +# We use Werror, since some versions of clang report unknown command line flags +# as a warning only. -BOOT_CFLAGS += $(DARWIN_MDYNAMIC_NO_PIC) -BOOT_LDFLAGS += $(DARWIN_NO_PIE) +# We only need to determine this for the host tool used to build stage1 (or a +# non-bootstrapped compiler), later stages will be built by GCC which supports +# the required flags. -# Similarly, for cross-compilation. -STAGE1_CFLAGS += $(DARWIN_MDYNAMIC_NO_PIC) -STAGE1_LDFLAGS += $(DARWIN_NO_PIE) +BOOTSTRAP_TOOL_CAN_USE_MDYNAMIC_NO_PIC := $(shell \ + $(CC) -S -xc /dev/null -o /dev/null -Werror -mno-dynamic-no-pic 2>/dev/null \ + && echo true) -# Without -mno-dynamic-no-pic support, add -mdynamic-no-pic just to later -# stages when we know it is built with gcc. -STAGE2_CFLAGS += $(DARWIN_GCC_MDYNAMIC_NO_PIC) -STAGE3_CFLAGS += $(DARWIN_GCC_MDYNAMIC_NO_PIC) -STAGE4_CFLAGS += $(DARWIN_GCC_MDYNAMIC_NO_PIC) +@if gcc-bootstrap +ifeq (${BOOTSTRAP_TOOL_CAN_USE_MDYNAMIC_NO_PIC},true) +STAGE1_CFLAGS += -mdynamic-no-pic +else +STAGE1_CFLAGS += -fPIC +endif +# Add -mdynamic-no-pic to later stages when we know it is built with GCC. +BOOT_CFLAGS += -mdynamic-no-pic +@endif gcc-bootstrap + +@unless gcc-bootstrap +ifeq (${BOOTSTRAP_TOOL_CAN_USE_MDYNAMIC_NO_PIC},true) +# FIXME: we should also enable this for cross and non-bootstrap builds but +# that needs amendment to libcc1. +# CFLAGS += -mdynamic-no-pic +# CXXFLAGS += -mdynamic-no-pic +else +CFLAGS += -fPIC +CXXFLAGS += -fPIC +endif +@endunless gcc-bootstrap -- 2.41.0