From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id 113963858D32 for ; Thu, 10 Aug 2023 14:05:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 113963858D32 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-686efa1804eso674781b3a.3 for ; Thu, 10 Aug 2023 07:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1691676344; x=1692281144; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=iIsU3d7vmijTPeTT3Epz86AgfuKg0p94VZmPUlywxxM=; b=Rlc3LrSl+ERXDW7AF9t/KBIpyH2iv9eHglTAU/FIsSsjjBcL9oSCQP7puQ99VgytmC IE20ByfVP/FVZuGWwvhes7Tk6WYO/xdPOjLEFCLTwTCML45xnFNXsap4MzpzeNPA4gO1 izh1+ey4yRVIzm1VBCXHjuwvbZY5F0XQYCy5W40m25LZWa/CyYpY63ZPwQyiZlYW3vqi A05usNWi2J0cfPzewEVIRF5vZ55qnFRnZQaxxfe0ynN3sE+mXBZnCjdDxYAFGKjvJKyM vNCGRbc0pnsf7zLPeadnvvjSQUXmjDVCXSREqmGL3upQE9L1rbhFLKRyKMDj+bB4eVUM +rrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691676344; x=1692281144; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iIsU3d7vmijTPeTT3Epz86AgfuKg0p94VZmPUlywxxM=; b=ZlaMy12nDR93ZyZEozaLxLl0/0b1ymto8QuFIA2iaJ+HQe67QCRoqKq5yqFid1auHs HSiB0vXi2pON8qfvCtkdd/hv8KlBcMNPxprcUsCHoZUjVc563PGojykkA3cExBHMWDLu KA6BTk0v11lKR5Aui/KCx0O3NwY7ORmkpGAq32JqYx47yXuVPMEYdsyT3R6VPSc7troH j8oZVPGTreaqfC7yYxiDdeKUhIok0qMsLthDGmVBLxfu+LCD2ANQZdTWxM9jI1y4tx4T uIOYoZm0O9gqpljdDud9WZlkNbPlR4Z6RjELxdA8suMzYfn6f7vylGQ6Iz+rhXqRbpeU W5ow== X-Gm-Message-State: AOJu0YwM+vQq5AvXTRh/vGehelFE7RbedCJ3jVyHt7W04W5LjCE8gDIg QBLUVy6axJK8fsTPNzIBHIsHzg== X-Google-Smtp-Source: AGHT+IERY+VbQug14lhH/G+mh1VF2aN1ffmsXV5Dx3xILDNZoIQaN1nMBKQheNN/yBYvqVKPwW/kiQ== X-Received: by 2002:a05:6a20:7fa8:b0:134:40f0:5d04 with SMTP id d40-20020a056a207fa800b0013440f05d04mr3222332pzj.13.1691676343838; Thu, 10 Aug 2023 07:05:43 -0700 (PDT) Received: from hsinchu26 (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id fm26-20020a056a002f9a00b0064928cb5f03sm1562130pfb.69.2023.08.10.07.05.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Aug 2023 07:05:42 -0700 (PDT) Date: Thu, 10 Aug 2023 14:05:38 +0000 From: Andy Chiu To: "Maciej W. Rozycki" Cc: Greg Savin , Greentime Hu , linux-riscv@lists.infradead.org, gdb-patches@sourceware.org, Andrew Burgess Subject: Re: [PATCH] RISC-V: support for vector register accesses via ptrace() in RISC-V Linux native Message-ID: <20230810140537.GA17787@hsinchu26> References: <20230803230110.904724-1-greg.savin@sifive.com> <20230810103510.GA2509@hsinchu26> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Maciej, On Thu, Aug 10, 2023 at 12:40:12PM +0100, Maciej W. Rozycki wrote: > On Thu, 10 Aug 2023, Andy Chiu wrote: > > > > > The SIGILL guard is being used as a wrapper around determination of the > > > > VLENB CSR, which is not part of the ptrace() payload for vector registers, > > > > at least as it exists at head-of-tree Linux kernel. GDB or gdbserver > > > > needs to know VLENB in order to construct the architectural feature > > > > metadata that reports an accurate width for the vector registers. If not > > > > for the VLENB determination specifically, and the lack of this information > > > > via ptrace(), then there would be no motivation for executing a vector > > > > instruction directly. It's a workaround, basically. I guess I could > > > > inquire in Linux kernel land regarding whether the NT_RISCV_VECTOR ptrace() > > > > payload could be enhanced to provide VLENB. > > > > > > I think the kernel interface needs to be clarified first, before we can > > > proceed with the tools side. > > > > > > I can see the vector state is carried in a REGSET_V regset, which in turn > > > corresponds to an NT_RISCV_VECTOR core file note. I can see that besides > > > the vector data registers only the VSTART, VL, VTYPE, and VCSR vector CSRs > > > are provided in that regset, and that vector data registers are assigned > > > a contiguous space of (32 * RISCV_MAX_VLENB) bytes rather than individual > > > slots. > > > > > > So how are we supposed to determine the width of the vector registers > > > recorded in a core file? I'd say the RISC-V/Linux kernel regset API is > > > incomplete. > > > > Does it make sense to you if we encapsulate this with a hwprobe syscall? > > e.g provide a hwprobe entry to get system's VLENB. We will have to > > increase and rearrange the buffer for NT_RISCV_VECTOR if we want to use > > ptrace as the entry point for this purpose. I am not very sure if it'd be > > too late to do though. > > No, how do you expect it to work with a core dump (that can be examined > on a different system, or with a cross-debugger)? You need to change the > API I'm afraid; it's unusable anyway. It's a pity the toolchain community > wasn't consulted if you weren't sure how to design the interface. Better > yet it would have been to implement the GDB side before the kernel part > has been committed. Conor just reminded me that we may still have a chance to get it right since 6.5 has not been released yet. I will send a fix patch to address this issue once the discussion settle down. After looking into some code, I think it is possbile to steal the unused space in datap and change the uapi with something like this: diff --git a/arch/riscv/include/uapi/asm/ptrace.h b/arch/riscv/include/uapi/asm/ptrace.h index e17c550986a6..ba6ddf4f9dc9 100644 --- a/arch/riscv/include/uapi/asm/ptrace.h +++ b/arch/riscv/include/uapi/asm/ptrace.h @@ -97,14 +97,17 @@ struct __riscv_v_ext_state { unsigned long vl; unsigned long vtype; unsigned long vcsr; - void *datap; + union { + void *datap; + unsigned long vlenb; + }; /* * In signal handler, datap will be set a correct user stack offset * and vector registers will be copied to the address of datap * pointer. * - * In ptrace syscall, datap will be set to zero and the vector - * registers will be copied to the address right after this + * In ptrace syscall, the space for datap will be set to vlenb and the + * vector registers will be copied to the address right after this * structure. */ }; Now ptrace will have the knowlege of vlen to parse V rsgisters. And this will not cause any size change to the original data structure that is shared by both signal and ptrace because vlenb is XLEN, which has the same size as a pointer in both ilp32/lp64. > > Maciej Thanks, Andy