From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 765CF3858D32 for ; Thu, 10 Aug 2023 18:08:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 765CF3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1b9c5e07c1bso10702995ad.2 for ; Thu, 10 Aug 2023 11:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691690938; x=1692295738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iU+C7JV6FbRgzBVC3R2lwvlAYCK7PTnMEPRpbCh3lQ4=; b=u4xReyEiduAa4QPqqP4aQsYdKCZivVj0uaVEqP0oyPLjnVa8DiZ8D5d2MGwoN2gAd5 GBZt/t6yOI+Htsj/gKii8+DYYD92KcZNnhsRX4KvXe7e1iUbawOCVPyO88Z8F/0DAG/S EUVOXSRR4NmmLIuYDpBYXI9KOM/I34Qyi9OjRfDtBKRF0ijwAWdDCp6s91zJVqIhF4Dm Mm1SW3q4FKhImBQLSDsoZVGCBw3qe6vm2kS+nAOHgWr69xrRkxVlZY8cQdssaEzk6chd c/cfNHJVUvqVgrvK+Hi+CC7MVgD3BwB7ISe7DiHgDcte57ihOzXLU5mb5gDTctmbeA5C QRNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691690938; x=1692295738; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iU+C7JV6FbRgzBVC3R2lwvlAYCK7PTnMEPRpbCh3lQ4=; b=QU4oGuDH9hUSxoFzI/Yw2pvrcaLC2jBLFyLy1lU2Talt13pdhqmUc92itElLJVEfpv K5NtrMjM/85Vun3alHYuiNzjJS3xSAIH1HpN8EbrHzYtAfkcopZGVyitahDA1PrPvLr6 uHwQaDsdSu5JWHIe+zqcdxHEjh4vgroIxkDUqVJu23oP1G3DxHOX5uqtqer55IpPNACy 7op6Lzmm7T10uj4wDT7lbZ0rGBnUlyhN/H9PABDivU2Ml1vEsQrjSO64ZkpDY6shJSdF zuvSrAHvWHMsc8za6Sdd2tP6d7lhhIwRCg9OYme8kyjFCT3+pQ33s2E8A/FnrWD5arYo oPzw== X-Gm-Message-State: AOJu0Yz89KhXBT4LAxOq8TDTzPcX4l1bCYxcQX5fGcUN00b9QzF2IUDN LcHAHtFEELJ6aWYHQNiZl33+0g== X-Google-Smtp-Source: AGHT+IG9CaD3itHY1VXsxUaoP/wll9eupisFYO/QWFELt+lNRDjEfS8WhUUaC30jFme5671xc50gVw== X-Received: by 2002:a17:902:e741:b0:1bb:8e13:deba with SMTP id p1-20020a170902e74100b001bb8e13debamr3233468plf.11.1691690938381; Thu, 10 Aug 2023 11:08:58 -0700 (PDT) Received: from stoup.. ([2602:47:d483:7301:9e4d:b830:d4fd:9164]) by smtp.gmail.com with ESMTPSA id b14-20020a170902b60e00b001bd41b70b65sm2085212pls.49.2023.08.10.11.08.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Aug 2023 11:08:57 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , gdb-patches@sourceware.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 4/4] gdbstub: don't complain about preemptive ACK chars Date: Thu, 10 Aug 2023 11:08:52 -0700 Message-Id: <20230810180852.54477-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230810180852.54477-1-richard.henderson@linaro.org> References: <20230810180852.54477-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: Alex Bennée When starting a remote connection GDB sends an '+': /* Ack any packet which the remote side has already sent. */ remote_serial_write ("+", 1); which gets flagged as a garbage character in the gdbstub state machine. As gdb does send it out lets be permissive about the handling so we can better see real issues. Signed-off-by: Alex Bennée Cc: gdb-patches@sourceware.org Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230810153640.1879717-9-alex.bennee@linaro.org> Signed-off-by: Richard Henderson --- gdbstub/gdbstub.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 20b6fe03fb..5f28d5cf57 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -2074,6 +2074,11 @@ void gdb_read_byte(uint8_t ch) gdbserver_state.line_buf_index = 0; gdbserver_state.line_sum = 0; gdbserver_state.state = RS_GETLINE; + } else if (ch == '+') { + /* + * do nothing, gdb may preemptively send out ACKs on + * initial connection + */ } else { trace_gdbstub_err_garbage(ch); } -- 2.34.1