From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=lySg=D4=lancelotsix.com=lsix@sourceware.org>
Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111])
	by sourceware.org (Postfix) with ESMTPS id 415F23857020
	for <gdb-patches@sourceware.org>; Fri, 11 Aug 2023 13:19:11 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 415F23857020
Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=lancelotsix.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=lancelotsix.com
Received: from octopus (unknown [IPv6:2a02:390:9086:0:2bab:b31e:a91e:47b0])
	by lndn.lancelotsix.com (Postfix) with ESMTPSA id BDB1B80AB2;
	Fri, 11 Aug 2023 13:19:09 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lancelotsix.com;
	s=2021; t=1691759949;
	bh=1FrCqVkTI6OD6tbJxdKs9b8JQVIeuOCF06WNCnP/EBM=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=WukIG/oTe/dc+3WXob0Zjr5zlMHFp7pOZT+OTq+KCixFs+06pUosLnp5XCzoyiVE5
	 PftobBXTkJ0Mgz9PgEgqEZZDWdxty46ZpMXHuJSAVpIOaO/rDptfBZzcaipwkMf4Mp
	 hkpoe+5Gvm0+AY17+fI/Ux10msKHDAVemRH+s0o+OdvBDPc5sNbQ416AqXQn/zjD2+
	 o4O7djoUQLHpB3ocuXomxNVcVLlxpl/r8C0jpqvNzxWijSDx6u044OvFxkYEB4Q2fS
	 ZvD404VxCgwghYzrJ2mC/R7axuyLTMRDpZxc12z3hY1q/d7VILga8TkGj0ssyWtte+
	 9LU9LHYQaJQcg==
Date: Fri, 11 Aug 2023 14:19:05 +0100
From: Lancelot SIX <lsix@lancelotsix.com>
To: Guinevere Larsen <blarsen@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: XFAIL some gdb.base/fileio.exp
Message-ID: <20230811131849.4inda7bmhiroknpl@octopus>
References: <20230811102134.2796842-1-blarsen@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230811102134.2796842-1-blarsen@redhat.com>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (lndn.lancelotsix.com [0.0.0.0]); Fri, 11 Aug 2023 13:19:09 +0000 (UTC)
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

Hi Guinevere,

I am not a big fan of the idea of running the testcases as root… but I
guess this is what you have when running within a container.

> +# Return 1 if the test is being run as root, 0 otherwise
> +
> +gdb_caching_proc root_user {} {
> +    # ID outputs to stdout, we have to use exec to capture it here
> +    set user [exec id]

Shouldn't it be `[remote_exec target]` instead?  You are interested in
who will end up running the test executable, which can be different from
who runs `runtest` locally.  I am not entirely sure if it should be
`host` or `target`.  I would think `target`, but the testcase does use
`host`, which seems odd to me.

Also, what happens if the underlying filesystem is for example a NFS
mount?  I am not sure being root will change what unlink can do, but I
have not tested.  Maybe it is not worth trying to figure out all setups,
if it comes up one can always adjust the test.

Best,
Lancelot.

> +
> +    regexp -all ".*uid=(\[0-9\]+).*" $user user uid
> +
> +    return [expr $uid == 0]
> +}
> +
>  # Always load compatibility stuff.
>  load_lib future.exp
> -- 
> 2.41.0
>