From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7DCF03858D32 for ; Sun, 13 Aug 2023 04:11:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7DCF03858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691899885; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PGfaC56D/caFHAwTetYylPuHaY/5JcjueaK5H2Z4md4=; b=Wlazxs4NrBPnEtNwnL+DxT/6/Hsp29yEvppNRWgXiCIBgbXVRh/0mJJynS6FiUDfIGzFsa daUtf8OV8mdwF4jQETN/fax+QsqTgMgzIjLLUFhF52TGBVmKpjzqdOYieDW/scbL/t0BPc nXoCfT8hzliBemw0qiuY/zKlFOLA9Yw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-157-a7LkP0yFPhOYIqOUGgJyuA-1; Sun, 13 Aug 2023 00:11:21 -0400 X-MC-Unique: a7LkP0yFPhOYIqOUGgJyuA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5ABB1101A59A; Sun, 13 Aug 2023 04:11:21 +0000 (UTC) Received: from f37-zws-nv (unknown [10.22.32.15]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B755B140E91C; Sun, 13 Aug 2023 04:11:20 +0000 (UTC) Date: Sat, 12 Aug 2023 21:11:19 -0700 From: Kevin Buettner To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Tom Tromey Subject: Re: [PATCH] [gdb/symtab] Don't deduplicate variables in gdb-index Message-ID: <20230812211119.20413b22@f37-zws-nv> In-Reply-To: <20230804173542.3357-1-tdevries@suse.de> References: <20230804173542.3357-1-tdevries@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 4 Aug 2023 19:35:42 +0200 Tom de Vries via Gdb-patches wrote: > Fix this in symtab_index_entry::minimize, by not deduplicating variables. > > Tested on x86_64-linux, with target boards unix and cc-with-gdb-index. LGTM. Reviewed-by: Kevin Buettner