From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 7BB9A3858C1F for ; Mon, 14 Aug 2023 12:24:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BB9A3858C1F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8FB701F383 for ; Mon, 14 Aug 2023 12:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1692015887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dCg/76RibAegHj/Oa4aEc8OqGA3CJpdo3NttjwsUo2c=; b=UHhCxUdwUUw9QcYjlDU6duoLcAiPshATYVPpTMIykEduJdNgOhvAV7Qx6RH/roC62aLlGp iZD4bAl+VTF6AjxK8xXItgwHHG7leglVuyMt0lW3L4d9zsa1oROoGUH4ZXogqIZrO7lNzs UjquMtgEUewIv4Jm4h+EHIlMIcy3U58= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1692015887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=dCg/76RibAegHj/Oa4aEc8OqGA3CJpdo3NttjwsUo2c=; b=dxMBWb/6RWC2xVsV18I4QSIWRsMsFXGrjdbf/ndGzIZ8a4W6aCk3j0JxQq/L10N2WqXd+Q cmhWuGVo0TpBkXBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7A659138EE for ; Mon, 14 Aug 2023 12:24:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EYu5HA8d2mSiPgAAMHmgww (envelope-from ) for ; Mon, 14 Aug 2023 12:24:47 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/build] Fix YYSTYPE and yyalloc odr violation Date: Mon, 14 Aug 2023 14:24:41 +0200 Message-Id: <20230814122441.20617-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When building gdb with -O2 -flto I run into: ... ada-exp.c.tmp:576:7: error: type ‘union YYSTYPE’ violates the C++ One \ Definition Rule [-Werror=odr] ... Fix this by renaming to ada_YYSTYPE and likewise for other .y files. Likewise for yyalloc. Tested on x86_64-linux. PR build/22395 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=22395 --- gdb/Makefile.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index 8521e8d11c8..ccdd84beea6 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -2509,6 +2509,8 @@ po/$(PACKAGE).pot: force -e 's/\([ \t;,(]\)free$$/\1xfree/g' \ -e '/^#line.*y.tab.c/d' \ -e 's/YY_NULL/YY_NULLPTR/g' \ + -e "s/YYSTYPE/$(subst -,_,$*)_YYSTYPE/g" \ + -e "s/yyalloc/$(subst -,_,$*)_yyalloc/g" \ < $@.tmp > $@.new && \ rm -f $@.tmp && \ mv $@.new $@ base-commit: 7a379ae2383034ad79a0c46b87a08ff1facd25c3 -- 2.35.3