From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 0CFDF385B527 for ; Tue, 15 Aug 2023 18:13:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0CFDF385B527 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 411261FD65 for ; Tue, 15 Aug 2023 18:13:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1692123217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s5XPmUltyozcW7HmT87I48cMm9g0fnjf2vPkiWK9cOI=; b=Qt4bjlTAPxQsh5i2p11vAFBuxtjukIJJ8jkZazj1lir327/vKXziFCmhjroW6omn0fbelZ 63buaHZm83PhOOd1NpTreJXFg5xWYIdrKSTT4XHMfvfysoCIfVj57b+5sXGgtrkjzd3m2u iX/cSFIcJuTqe9caSVBzqptkqI3IgpU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1692123217; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s5XPmUltyozcW7HmT87I48cMm9g0fnjf2vPkiWK9cOI=; b=YNElc6PwrbcPehkr63k0IGG82R6VW7LigisacGVqDqynrwAm5EMLYjR00nS0E99dLM1CVz SIZNYCWNDoqCqaDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2F2C71390C for ; Tue, 15 Aug 2023 18:13:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id eGWVClHA22RuQAAAMHmgww (envelope-from ) for ; Tue, 15 Aug 2023 18:13:37 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 6/7] [gdb/build] Return reference in target_read_auxv Date: Tue, 15 Aug 2023 20:13:08 +0200 Message-Id: <20230815181309.8595-7-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20230815181309.8595-1-tdevries@suse.de> References: <20230815181309.8595-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: In target_read_auxv we return a copy of an object: ... gdb::optional target_read_auxv () { ... return info->data; } ... Return a reference instead, saving a copy. This is exposed by using std::pmr::polymorphic_allocator instead of std::allocator in default_init_allocator. Tested on x86_64-linux. --- gdb/arm-fbsd-tdep.c | 2 +- gdb/auxv.c | 6 +++--- gdb/auxv.h | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/gdb/arm-fbsd-tdep.c b/gdb/arm-fbsd-tdep.c index acafc4a8bcd..fe1c7f453c9 100644 --- a/gdb/arm-fbsd-tdep.c +++ b/gdb/arm-fbsd-tdep.c @@ -244,7 +244,7 @@ arm_fbsd_read_description_auxv (const gdb::optional &auxv, const struct target_desc * arm_fbsd_read_description_auxv (bool tls) { - gdb::optional auxv = target_read_auxv (); + gdb::optional &auxv = target_read_auxv (); return arm_fbsd_read_description_auxv (auxv, current_inferior ()->top_target (), current_inferior ()->gdbarch, diff --git a/gdb/auxv.c b/gdb/auxv.c index 812b2807554..02b4ab4cdd0 100644 --- a/gdb/auxv.c +++ b/gdb/auxv.c @@ -354,7 +354,7 @@ invalidate_auxv_cache (void) /* See auxv.h. */ -gdb::optional +gdb::optional & target_read_auxv () { inferior *inf = current_inferior (); @@ -410,7 +410,7 @@ target_auxv_search (const gdb::byte_vector &auxv, target_ops *ops, int target_auxv_search (CORE_ADDR match, CORE_ADDR *valp) { - gdb::optional auxv = target_read_auxv (); + gdb::optional &auxv = target_read_auxv (); if (!auxv.has_value ()) return -1; @@ -564,7 +564,7 @@ fprint_target_auxv (struct ui_file *file) struct gdbarch *gdbarch = target_gdbarch (); CORE_ADDR type, val; int ents = 0; - gdb::optional auxv = target_read_auxv (); + gdb::optional &auxv = target_read_auxv (); if (!auxv.has_value ()) return -1; diff --git a/gdb/auxv.h b/gdb/auxv.h index 2441b6c02ab..f42efa4fa7b 100644 --- a/gdb/auxv.h +++ b/gdb/auxv.h @@ -48,7 +48,7 @@ extern int svr4_auxv_parse (struct gdbarch *gdbarch, const gdb_byte **readptr, /* Read auxv data from the current inferior's target stack. */ -extern gdb::optional target_read_auxv (); +extern gdb::optional &target_read_auxv (); /* Read auxv data from OPS. */ -- 2.35.3