From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id E6CEF385DC07 for ; Thu, 17 Aug 2023 15:10:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E6CEF385DC07 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 055231F37E for ; Thu, 17 Aug 2023 15:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1692285035; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oCJkg9faI+MULlvPEDliTFQVbvMdbxKD9a7Ej4vulGg=; b=ucbtsb2zXm8PN6vdnwc7dEsiaKHUXMOnqwdFwAhLlEKDKuZgLPbqzrTC9Oh62+8M8Fkj1u HSdpsdXimEfqrHcct/EHhmWbYxNWMIjY105IaHG8jirYC+uk6lPXzCtaFn7PVUYn4XvuOK 1BiOj4+nL62/tpLeaTcX4Dx9p7FsTKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1692285035; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=oCJkg9faI+MULlvPEDliTFQVbvMdbxKD9a7Ej4vulGg=; b=+CmubMXnb9fdj6S+/K8xBRkBXIme/7xt5yhDDPZus1/2xArJ6LpVcFi9/PkwASPMxe8UnQ 5mMG1nL8W3TdwKAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E751F1392B for ; Thu, 17 Aug 2023 15:10:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id u4VSN2o43mSDPgAAMHmgww (envelope-from ) for ; Thu, 17 Aug 2023 15:10:34 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH] [gdb/build] Fix yysymbol_kind_t odr violation Date: Thu, 17 Aug 2023 17:10:06 +0200 Message-Id: <20230817151006.12971-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_STOCKGEN,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When building gdb with -O2 -flto on openSUSE Tumbleweed (using bison 3.8.2) I run into: ... ada-exp.c.tmp:653: warning: type 'yysymbol_kind_t' violates the C++ One \ Definition Rule [-Wodr] c-exp.c.tmp:398: note: an enum with different value name is defined in \ another translation unit ada-exp.c.tmp:660: note: name 'YYSYMBOL_NULL_PTR' differs from name \ 'YYSYMBOL_COMPLEX_INT' defined in another translation unit c-exp.c.tmp:405: note: mismatching definition ... Fix this by renaming to ada_exp_yysymbol_kind_t and likewise for other .y files. Tested on x86_64-linux. PR build/22395 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=22395 --- gdb/Makefile.in | 1 + 1 file changed, 1 insertion(+) diff --git a/gdb/Makefile.in b/gdb/Makefile.in index ccdd84beea6..54c5312e19a 100644 --- a/gdb/Makefile.in +++ b/gdb/Makefile.in @@ -2511,6 +2511,7 @@ po/$(PACKAGE).pot: force -e 's/YY_NULL/YY_NULLPTR/g' \ -e "s/YYSTYPE/$(subst -,_,$*)_YYSTYPE/g" \ -e "s/yyalloc/$(subst -,_,$*)_yyalloc/g" \ + -e "s/yysymbol_kind_t/$(subst -,_,$*)_yysymbol_kind_t/g" \ < $@.tmp > $@.new && \ rm -f $@.tmp && \ mv $@.new $@ base-commit: 05fbbeacaa761976fea5580d993aa6cb7f5342a0 -- 2.35.3