From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 8EF253857703 for ; Mon, 21 Aug 2023 17:02:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8EF253857703 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37LFxLPf031511 for ; Mon, 21 Aug 2023 17:02:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : content-transfer-encoding : content-type : mime-version; s=corp-2023-03-30; bh=7pOBs51N8SrAIUGxhc44834jP6ahT8KqtGJU4rv2Ass=; b=Ag4I36LtyYsCo28MsVwIDoB8kOryTecocFjbV/C2FAsJBtQcWJlveTGkxrv5K3bhPwgP rLFFVBPBh7vNYu71SFJGNBJ0N36ogQfQ+zxQhCNF84+GsEqDfpM9QYrfIK51jfXkUkhY kCXZTPQfRihwCz4OUlKvh9rVot/Y7ge14vFs1ekbMdzvZTk1UJy4i7MOQAH7vmwGrtYT oW9MG9+8rJ3QtZVuCBqutoi/4slxI6JvJowR8FAujMJLJ/hnjuN+LOzuvczYdDXX28Ar +URhE1x9B8NxxVFIAaTh232Cz3jep7Jw6gasUmWTT8XKOM8USlRp4/TkpSD5NnocmulW tQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3sjnscbcv4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 21 Aug 2023 17:02:59 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 37LG7Q5d030360 for ; Mon, 21 Aug 2023 17:02:58 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2169.outbound.protection.outlook.com [104.47.56.169]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3sjm63qnsj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 21 Aug 2023 17:02:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KFcs1xGogLGHrHRrWhinGCOJ4JsfA6Rt34aI4qLYsreKueVsenG/AJRPoUaHpA/R+z61bPiBqYVZsSR0iCObeOyO9uQhc3ushG1r47YzUQn8vGM5QTbWkEgIv9c7l+abnA4TitHeUVppm8w1e1q+zqUC6ZEgATp04utm5xfmusrFI8HBgHKAVTT757icUWlvotxRhxefL2v0MN7BuSiWyRzXQhI52l0UgM7BnUHe9xwvxrdNQ9WdRQsFy7ZZjzYq7ivr7qg195epaoSj9A7SIlgiQ5rn+RPIok+ioemKhGo4VB56ucrBiZgYuRP19xykQPUs2Ii8Xsr1/17NMR6oDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7pOBs51N8SrAIUGxhc44834jP6ahT8KqtGJU4rv2Ass=; b=d6PuAAUuIxstNQ2tDV1MK60uQANeNLppoD473NX53uOKHN96P3jQ9y3qb5fr1jRWWXTbz9Q5CT7wu+W8W/r/NhAr3CVbLDCwX3g15lCHsTm9wAt6G7PGpFKJuKZKuh1ZucmMnfp2NboLkkkwyjwYYT9Eb+eWZNXNrCSxHHMnnunYfdFOFHZClcgcjv3RRUjpHX4Txzbmd/9ODoHknSmjkYvzMDdehExU/XI80L0Ffh27kL7DhZFMwaU0w38zsJwxaw/AKqbmSGMuCnxB10NYHAm6MeGJ82KdvN+5zxjRUcf5aE/VZVNc3Fir0e5EAUcU5fUuCN5jW/Dl7HIOB2n04g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7pOBs51N8SrAIUGxhc44834jP6ahT8KqtGJU4rv2Ass=; b=KV6qOiu/FlEvQ70XQvfcXMocoXORFvQPGO/N6KsxdyEapdnSWHhuHs/OTfxZbzRPw9BcS2p6kFfFVdCYdR1N/8vgRM5M+jZYpFgequMnYZ1rvO7HXLHyNMCW6YBZ3C9phZIy18aa+om2vUi6kZ+nsOsFUZ8ABQAwQvpUBMPDw+E= Received: from MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) by PH0PR10MB6981.namprd10.prod.outlook.com (2603:10b6:510:282::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 17:02:56 +0000 Received: from MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::6269:77c6:e6b9:ac03]) by MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::6269:77c6:e6b9:ac03%6]) with mapi id 15.20.6699.022; Mon, 21 Aug 2023 17:02:56 +0000 From: David Faust To: gdb-patches@sourceware.org Cc: jose.marchesi@oracle.com Subject: [PATCH] sim: bpf: remove negi, neg32i insns Date: Mon, 21 Aug 2023 10:02:50 -0700 Message-ID: <20230821170250.6457-1-david.faust@oracle.com> X-Mailer: git-send-email 2.41.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SA9PR10CA0020.namprd10.prod.outlook.com (2603:10b6:806:a7::25) To MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3213:EE_|PH0PR10MB6981:EE_ X-MS-Office365-Filtering-Correlation-Id: e1e3afe4-3a7f-4c93-afc6-08dba26876e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K9X8DyCYsJ8qFkhNsxzc4STZ6Mv5Hyv31s82zd48xUmrF22c2EN2QSteWc19+EoZVGKwSvlzjirs/4gRLWYDpxoU42B41qHBU7mnyhgTjKPhDBi5DFjnMstfwUqqjMXA7zI5IzC9rty2FIuk2HSheNaeZ7cm1ElfUJVlwwhMufWgIf0T7HlJp4RfipbwjM0Rlcmsf1U+hGbsNvxJMo5RawOtrQfCC2ypT0o+rBE6hW3XLie7c5WWwDHtjTJ9TULJHhSgSvGjF2dO/QJPIjgPR+zGrGM4upLZCtClXapLwomTEzK5E1KOzncCucRrRdVGt4N0rU1eOHmo+mD3kXwifrazuFYB/w9pR75nDXIGUZpyhVW07TmAWQVCRzTtYdX38sFg7Ky79fxTZ8VXBkOHK5WPEyRKtYAl3jMMuNV64a6P7ZxF0H3LuSsc10cYT+ISkKswEngMbT2mJdT9o1pUs1g9T4p3rKKYkpmMxwJbypNTxFEuuU4WTTziMIfIrspZShcqiBmt6Sj4Oc6ZZD/W9Veiz6ZOn0GRfQGUtBtxH0A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR10MB3213.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(376002)(136003)(346002)(39860400002)(366004)(186009)(1800799009)(451199024)(6916009)(66476007)(66556008)(316002)(66946007)(6512007)(8676002)(8936002)(2616005)(107886003)(4326008)(1076003)(36756003)(41300700001)(966005)(478600001)(6666004)(38100700002)(6506007)(6486002)(83380400001)(2906002)(86362001)(44832011)(5660300002)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Js10JbEeH5CAvshBChL3wVh9OEdoQid8v1oyIaRWbrB4ZXoqteYChcm78wFG?= =?us-ascii?Q?2ei6ZPq5A51e+xwSuRxmgrL/sR7XEfQ6jaPdCXGyPxX8pQ7yU/0/C+wZL6nl?= =?us-ascii?Q?dy2QuzdPDMatQy5//pZNjhVDbWv6HgTgOATIxQ1RVTHd4b9E2G4Xc/l/dowd?= =?us-ascii?Q?rylF58kDMRswVSixXqcnFCKHNmGlwTtUwpWf6iszFkG+HTpQRo636Vb8YUNl?= =?us-ascii?Q?A5LFzjx/HyyDNS6IatUPDfgnYgZCsJbct8PftbHDd+u1ef4YAbcYB3JA1fyl?= =?us-ascii?Q?4GWLemde2CB+GXz3byRTUXEU7ABzfNtDWpCj1quSqQjizaal9NJHBGDMW3Rr?= =?us-ascii?Q?YolYOzmHxYZhH/v2yAXoYT94zMEb+iNzBETZWS3/hjqd0ekMYNdmrfS7+/h7?= =?us-ascii?Q?BllN6jZCfkgnOLt4IKiRgPdG7T1Pnd5Vr9rTHuN2U46E4Wehin8sV408iOvQ?= =?us-ascii?Q?xW4xFzRlSUH3qrOEW12vK71lLFinwkB4U5M5puK7BoAEpsfQQYF2y7VUtmT3?= =?us-ascii?Q?S8QuwqI3dlSAadNSgsTZrSdJfCCKNbaegTfdMPc/T7lR1K+u/Ceq1rOL3r6R?= =?us-ascii?Q?kox2UqXYu5D9DbJtsgB/25RFY5z4uMP3fd8McF8t2JhYFoCSbuspOC+O+yMk?= =?us-ascii?Q?u9zAPEPkFHiMz9ZYfeOMtLxWZRwK/uo2bdbDQNK7/p6G6N/4GoMrHTfPecff?= =?us-ascii?Q?GQ29i5xvA7hSt9QY0A61zHubblppWM4uJrm3XV0t3peXERh2UJ2y2eIy0pkp?= =?us-ascii?Q?rNH6xu30533Zc760CmemdI+vS1474IR+g2iSp+xYQh2OT+snuTD8+GjsJCRv?= =?us-ascii?Q?UKVrZBX9evEb7eKb7gzhJh94vdSNSUGgiiIOHMt0276T0fpW9HuNoRuGkSEy?= =?us-ascii?Q?OVXVRnqkvLbx/F3vxGSvRTOseVyMd0DnciPR2P1DjDlO4ozSfBMsi8Kvx75E?= =?us-ascii?Q?aBbcqyLGRG/e4AA9twOAip5KbrjEXETU2iK4Kfu6HUz44HB0eW2wMFxOulPc?= =?us-ascii?Q?lS5P8BZvthHSwC2NEhYvzKnW6itutWtrzeRy+hd4jFLjPdDsM8Reiaaz+tGw?= =?us-ascii?Q?tmKwY3KXhCt5ko0UHSse+RwHiSCb0v194nUP2j7Hn2SNYxXBRxuS1axSAfXJ?= =?us-ascii?Q?5YQIxcnlsyMFErPvF216lJusmF1XVX1B0CcbvoANLhD3DLJ4rHqwXtYW+oUk?= =?us-ascii?Q?vssAoNV4cbf81PsjaFeZiu0p3pPl2+k8hE667H/6yJ0isMSdEfwkw7Ja9gKl?= =?us-ascii?Q?V6FqB55sV4evUNxFA2374uEz6GupewIPErTl/1dksIrrb7JmwVEpvENSZSwI?= =?us-ascii?Q?dA3ibr1Q0rYP19D/U8aVYFuOnKbGjaHZnx/2RYK699K+grSTLW7DGQL4Hyqr?= =?us-ascii?Q?bVYhyAtNK7K0Mkgl5ALO89b43RoKogzIyhqFWzcpIrTX0bCscPT1nqXOas9s?= =?us-ascii?Q?XCkFfVSlEJVQ/3qdyfvy9rbIQIrT2MjnoDS0eMoMzMO+Z8/BCFjzfXh8TMFD?= =?us-ascii?Q?bKVbg2HY7/A/Pgwq4FFy2OnjnJCsVZxyA4l2I7H6j3mbZwmzS+6lWWISTrNV?= =?us-ascii?Q?2/2q/Sp9mSCTFVEJA+2VOv/3yK8/ZAkL2qvfJHGh?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: LprcYbYS9N5rhERqzJGAW3EgxOlzj1+DS9THZJuLAS1gJhCob5RzNBZWDdlnO5AJzHQm7nWgcmAMPyg7r6XBL1eCeUOE92GZgRT/gktHBHsIqB7Pyy6CJVMPh6sLASpZIM3Exjv5AYdEXDM0Dcu1uKjcYBuR8D3uAF0gIY4MoESXTF/KAnapMwbh75jVteSh2ZZ8uTjmuSCCIFHzmn6pecz0nASv4frptNaQwQsfW91fVvPabnhiwmtEyDrXwFtMGKhJDG5BTPOCl+5ef0PHAJ4dJTttzvbx5ZCsvK4WQygBM/8SDM/xgGbrmmS7C4Llk7geL4q1qYdoaDUHl/Ptw3JHzD8AHHtNV3zyKOEx9nIW54conNFxzOzmVViRDrJiHEVIF2o+DRzDpTB2sTDGSyNQnWEymqRqQpo6SxGSeERD0lfEYxUDFCsRCwrvwl/5XHo+0lLk/q57k4we4z8jSZqJUoE2VB46J+zZosJXq8S7xLaGw6gZD6gCbVoSJpFo0bKC44zQYNp10PyIVV6gwD8eBqV8dPEuzQ/QPRSLsXnPenmoxnCN9G/957jIB21mxR+c9G8s/U5xgXo3SIMzHRkGEbCDE2+PQqkcFCs6bzEWvkmGKuRwXd4j/TTxYAZP45nbOnbJDxDw2o1E5hU6hQzfDUOkBI+fNzK3axzt8Ja0RQ17gpNxnajXtr7/ElUg7BzSwcd1mAx6tyn/9N8zJ/KGYvH7SWyMONt5jc8qhAx/mgxLvEHykOVKO7cm4KNi X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1e3afe4-3a7f-4c93-afc6-08dba26876e6 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3213.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 17:02:55.9378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MOF/cVlATxcmsq5Cu9ofkutfd4DGtbHrLmlfDmPAkJgwb0M2WQZRIw8qgch51prSfT+7vVMS23xXFpDUXEAnxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB6981 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-21_05,2023-08-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=518 malwarescore=0 bulkscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308210158 X-Proofpoint-GUID: lVdjNZ0fyj4JJ0oavfJ8W6TeR0ifTKMI X-Proofpoint-ORIG-GUID: lVdjNZ0fyj4JJ0oavfJ8W6TeR0ifTKMI X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The BPF virtual machine does not support neg instructions operating on immediates, and these erroneous instructions were recently removed from gas. Remove them from the simulator as well. binutils patch: [PATCH] bpf: correct neg and neg32 instruction encoding https://sourceware.org/pipermail/binutils/2023-August/129135.html --- sim/bpf/bpf-sim.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/sim/bpf/bpf-sim.c b/sim/bpf/bpf-sim.c index 5e01ddeca9f..a4af22b2308 100644 --- a/sim/bpf/bpf-sim.c +++ b/sim/bpf/bpf-sim.c @@ -730,10 +730,6 @@ execute (SIM_CPU *cpu, struct bpf_insn *insn) BPF_TRACE ("BPF_INSN_NEGR\n"); bpf_regs[insn->dst] = - (int64_t) bpf_regs[insn->dst]; break; - case BPF_INSN_NEGI: - BPF_TRACE ("BPF_INSN_NEGI\n"); - bpf_regs[insn->dst] = - (int64_t) insn->imm32; - break; case BPF_INSN_LSHR: BPF_TRACE ("BPF_INSN_LSHR\n"); bpf_regs[insn->dst] <<= bpf_regs[insn->src]; @@ -867,10 +863,6 @@ execute (SIM_CPU *cpu, struct bpf_insn *insn) BPF_TRACE ("BPF_INSN_NEG32R\n"); bpf_regs[insn->dst] = (uint32_t) (- (int32_t) bpf_regs[insn->dst]); break; - case BPF_INSN_NEG32I: - BPF_TRACE ("BPF_INSN_NEG32I\n"); - bpf_regs[insn->dst] = (uint32_t) - (int32_t) insn->imm32; - break; case BPF_INSN_LSH32R: BPF_TRACE ("BPF_INSN_LSH32R\n"); bpf_regs[insn->dst] = (uint32_t) bpf_regs[insn->dst] << bpf_regs[insn->src]; -- 2.40.1