From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2077.outbound.protection.outlook.com [40.107.20.77]) by sourceware.org (Postfix) with ESMTPS id 35ABE3857707 for ; Tue, 22 Aug 2023 11:21:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 35ABE3857707 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BczB8afK+RjgGTMO4w42hjr23P4EF7xpsp+nJJv6QjU=; b=uJ4bLjzUD0vZe6LwiOcuqJPMa9m5J2DtKvGxXJrMbMKMkMi13ngcGoHvqVkFYW14HVgnbxEzxgUdZ14fRkWIBQBfBTK2A4w9TIPmSFlMZi2RpBkXYk0D4m9PyKyVkZI5kViRvn74rmwDvbK6Bc69q3gB0L2G+RDAD0E0ShTEqaM= Received: from AS9PR06CA0738.eurprd06.prod.outlook.com (2603:10a6:20b:487::25) by GV2PR08MB8343.eurprd08.prod.outlook.com (2603:10a6:150:bb::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.20; Tue, 22 Aug 2023 11:21:46 +0000 Received: from AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:487:cafe::aa) by AS9PR06CA0738.outlook.office365.com (2603:10a6:20b:487::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.20 via Frontend Transport; Tue, 22 Aug 2023 11:21:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT031.mail.protection.outlook.com (100.127.140.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6723.15 via Frontend Transport; Tue, 22 Aug 2023 11:21:46 +0000 Received: ("Tessian outbound 0b7d6027328f:v175"); Tue, 22 Aug 2023 11:21:46 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 201e2b270e0a4a19 X-CR-MTA-TID: 64aa7808 Received: from df7f4ce8e75f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9DCA058C-5573-4B40-90B5-5C6143FF8169.1; Tue, 22 Aug 2023 11:21:39 +0000 Received: from EUR02-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id df7f4ce8e75f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 22 Aug 2023 11:21:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V+7JwzIPswjJTZ1J4jtmOKeyJfPQOHVoKsV7Eh5QRMxV08EGkWpancdt1VJgSRyXZksdJVQQUDp/F1Tw15ZHbvnmjQAxDZ5H+BuAmJDGCwI7okLQxAY2BwyEmUv4QpnqmaJ8Ez6vzxKpjCluKlAmhTyR2ccbHQl85WL8TbzIrcnzTsjeMFDHQEHZsPr8fgiOvkKbwlNKqKJVSQb4W4Qj7tfIJHVDBsEBOEGICzWghMV+9Lia0pwcqfOj9xHnYFVJiJm4zecFRDrWSiFp1TjRp7+EyUOK607xHOz0+FJO7BDSa/IM9C56Ab+h/0btUatRtftpkEKJq9jQviA2/Lhtyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BczB8afK+RjgGTMO4w42hjr23P4EF7xpsp+nJJv6QjU=; b=VKkWH8PSmSL4BL2bPIFIl5W1KxZxEE7jT4X04bFbdNbyBWRynF9aJGT4QTemFf9hkWmhbPNlzLK+Yny4YghAKVGFO8xgpt2/tPsuxHkBRgP01jyjTPYLT8wyniRFbhQfdlV17YiPsoCksbxYa+EJ3VaHnq8DH9sRJhUWnl0aKwJSWXqUdIuWycqVqN6XuAtui+9viHxzuugLRI+wSeF0yP7Otr2MmfmMvFeLRuKYwwoLmS4cRjC9u66U7/niW5iuLJLHcLN3Ue73qiOtLeAT9ItdRhNbea45ySgMvK6JAoJ8v4rrR+bTOWN8+VfPMYf63D8RU2LsujWSidRPGQu+CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BczB8afK+RjgGTMO4w42hjr23P4EF7xpsp+nJJv6QjU=; b=uJ4bLjzUD0vZe6LwiOcuqJPMa9m5J2DtKvGxXJrMbMKMkMi13ngcGoHvqVkFYW14HVgnbxEzxgUdZ14fRkWIBQBfBTK2A4w9TIPmSFlMZi2RpBkXYk0D4m9PyKyVkZI5kViRvn74rmwDvbK6Bc69q3gB0L2G+RDAD0E0ShTEqaM= Received: from AS9PR07CA0015.eurprd07.prod.outlook.com (2603:10a6:20b:46c::19) by DBAPR08MB5701.eurprd08.prod.outlook.com (2603:10a6:10:1a6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Tue, 22 Aug 2023 11:21:37 +0000 Received: from AM7EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46c:cafe::1a) by AS9PR07CA0015.outlook.office365.com (2603:10a6:20b:46c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.14 via Frontend Transport; Tue, 22 Aug 2023 11:21:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT027.mail.protection.outlook.com (100.127.140.124) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6723.15 via Frontend Transport; Tue, 22 Aug 2023 11:21:36 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 22 Aug 2023 11:21:35 +0000 Received: from e129171.cambridge.arm.com (10.1.34.58) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Tue, 22 Aug 2023 11:21:35 +0000 From: Luis Machado To: CC: Subject: [PATCH v4 01/16] [gdb/aarch64] Fix register fetch/store order for native AArch64 Linux Date: Tue, 22 Aug 2023 12:21:15 +0100 Message-ID: <20230822112130.1513216-2-luis.machado@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230822112130.1513216-1-luis.machado@arm.com> References: <20230822112130.1513216-1-luis.machado@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT027:EE_|DBAPR08MB5701:EE_|AM7EUR03FT031:EE_|GV2PR08MB8343:EE_ X-MS-Office365-Filtering-Correlation-Id: b543961c-0058-49cc-89fa-08dba301f8a5 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tQ3m/hQFel/7c6alw8urtvz8VxbhvHoKKgY20YFAQeeOgEoXsweD3nVc5wRj96JERkUNBb416BgY89lXUgPBSis5DYeYPNiFoVsudri3h745tKflRoD7yAMsfTR3ecJvtJMBUmtjMcfFxlrN8FLMI7q1NKrsqXV8BjvqIejTmMLCgpwvFNbqT8YIjBu8VZGLU8uVWQuMccpic+lqtJqcaItXBSvEl8bUs+H/rr/NKuSvofpkCd+Blt3CFVMe5qNUbrurWGuvBeMlpjzpYw9XMnSSj2DKvGgch+KSkKuAvFLqRUYwQCGsjIlxDdRFrxpsfdeaUhuujFcJqMHHRwTDRZzFDZM8DgfefWwG3Y8q0V+wzoiRSI+ZrqtT7DVdcqGjgUGXF6KWRpx0tjBn1D+QwgW/lrneV2pcvY5jp4ZgMq+89JXQnDiVsUOgkhz9Lxpu4EXpERrETozNCNu+b97dhg52zFrfJSk4Ic45XGxiTluPmoqZTtkrQYG0sLukvT7YUw4MmOhSo3Dnld+r1AsEZitQ1raLWNyiHVp9kSUq+MLxVWzri3KsNmRuVsFl3QBVmSHg1BgZwZF3284E5OuPjRvIAZlcbHuJrX1uxPAMOE0gM/qQ0WJS5MZuWT5xbowRVZKUbNeaeDLxn8+5pmG/c6tXsniwNjo+zKtbfhRNOICpibmPsROieBdMvL0ZEqNLwNyU5i7tr84x6ff8xZ2xM5J4ObgZ888wc7KS2FWFLDVMXs0JwjSV3qs0jpu+GqiT X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(136003)(376002)(396003)(39850400004)(346002)(1800799009)(186009)(451199024)(82310400011)(36840700001)(46966006)(6916009)(316002)(70586007)(70206006)(8676002)(8936002)(2616005)(4326008)(36756003)(41300700001)(1076003)(82740400003)(356005)(81166007)(478600001)(6666004)(40480700001)(83380400001)(2906002)(86362001)(47076005)(7696005)(36860700001)(336012)(44832011)(426003)(5660300002)(26005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5701 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ec961e61-35a6-4bb9-a8cb-08dba301f303 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vAE13v2cAcKlJ9rVMCLk+X1m5um/mAkeyJYtxMAgKIi8tMAE+N5qBtEqKTYVFEsQJz6RgljN/bFO9WlsJd6NcUqJiRNDSigtvn0VPsWEUxjNDauhk3a1+IQBKO5/I8bqM3Kqzc3nVaXPS+M0inaKUVjPO34InKkRQUVG+MUAfMVFdJQXZ1Z5kkzSd4RobiijRl/YF0EVhU4IMZtFsfPZNb8D3TPKam3AJd6oMSoiq8HB1BwBHLo9DKAfGx4tKcY5VO451HZyNPeg9WMNWrULeIF+NuC2/UA1GguG9lCsf05SycTX0W3c0HvWZZAbJ7s62iX0pmRv44DM/OeS1uoa13TiKqXjmn2AqADQraL4M7E9U96afsIgb5d4Id2Sy5CHhGcQlW/S87g6eaZd7M/78OWKbUIJ1dsLzOrwyd0ClO2cybGbBM5Oxl8KTbYOezS/+LkO1pRDiP/W9NzhWf8wT720JmwI+DM3uTN/fh8UhqEEWYsxLYIKa6/6SGN4Zq4s3Dm4REy60a7K1YQnU+Hpb7qRc/HWReeFThdUfLfFJJyh8tMEMHHbmwdGIuKw9jG2OfMs19BG0TV1K6Ylazw5Kfkcc2w6hZdHSM+ujCmR37Sy/5Y4OGNOmRq+2NX3YoaPDXT6FZfEJO4DAPToKof5B7VIsWv1en93VyHWuR1jigqx1rHeSLsVN89D1kaw+A+kvzhggLmw6zf8HM4wLc4NEPKnbWIvVmVxhrNgxmus0AHgxjr5xTRgZ4NqZ4TXXeJ+ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(376002)(396003)(136003)(346002)(39860400002)(186009)(1800799009)(451199024)(82310400011)(36840700001)(40470700004)(46966006)(8676002)(40460700003)(8936002)(4326008)(44832011)(5660300002)(2616005)(36860700001)(82740400003)(86362001)(81166007)(107886003)(336012)(6666004)(26005)(426003)(7696005)(1076003)(478600001)(47076005)(83380400001)(41300700001)(70206006)(70586007)(316002)(40480700001)(2906002)(6916009)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Aug 2023 11:21:46.4325 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b543961c-0058-49cc-89fa-08dba301f8a5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8343 X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Updates on v4: - Fix FPCR comparison and other review comments. --- I noticed we don't handle register reads/writes in the best way for native AArch64 Linux. Some registers are fetched/stored even if upper level code told us to fetch a particular register number. Fix this by being more strict about which registers we touch when reading/writing them in the native AArch64 Linux layer. There should be no user-visible changes due to this patch. Regression-tested on aarch64-linux Ubuntu 22.04/20.04. --- gdb/aarch64-linux-nat.c | 60 ++++++++++++++++++++++------------------- 1 file changed, 33 insertions(+), 27 deletions(-) diff --git a/gdb/aarch64-linux-nat.c b/gdb/aarch64-linux-nat.c index eeb9761bfe5..8844fc722cf 100644 --- a/gdb/aarch64-linux-nat.c +++ b/gdb/aarch64-linux-nat.c @@ -504,6 +504,7 @@ aarch64_fetch_registers (struct regcache *regcache, int regno) aarch64_gdbarch_tdep *tdep = gdbarch_tdep (regcache->arch ()); + /* Do we need to fetch all registers? */ if (regno == -1) { fetch_gregs_from_thread (regcache); @@ -521,28 +522,28 @@ aarch64_fetch_registers (struct regcache *regcache, int regno) if (tdep->has_tls ()) fetch_tlsregs_from_thread (regcache); } + /* General purpose register? */ else if (regno < AARCH64_V0_REGNUM) fetch_gregs_from_thread (regcache); - else if (tdep->has_sve ()) + /* SVE register? */ + else if (tdep->has_sve () && regno <= AARCH64_SVE_VG_REGNUM) fetch_sveregs_from_thread (regcache); - else + /* FPSIMD register? */ + else if (regno <= AARCH64_FPCR_REGNUM) fetch_fpregs_from_thread (regcache); - - if (tdep->has_pauth ()) - { - if (regno == AARCH64_PAUTH_DMASK_REGNUM (tdep->pauth_reg_base) - || regno == AARCH64_PAUTH_CMASK_REGNUM (tdep->pauth_reg_base)) - fetch_pauth_masks_from_thread (regcache); - } - - /* Fetch individual MTE registers. */ - if (tdep->has_mte () - && (regno == tdep->mte_reg_base)) + /* PAuth register? */ + else if (tdep->has_pauth () + && (regno == AARCH64_PAUTH_DMASK_REGNUM (tdep->pauth_reg_base) + || regno == AARCH64_PAUTH_CMASK_REGNUM (tdep->pauth_reg_base))) + fetch_pauth_masks_from_thread (regcache); + /* MTE register? */ + else if (tdep->has_mte () + && (regno == tdep->mte_reg_base)) fetch_mteregs_from_thread (regcache); - - if (tdep->has_tls () - && regno >= tdep->tls_regnum_base - && regno < tdep->tls_regnum_base + tdep->tls_register_count) + /* TLS register? */ + else if (tdep->has_tls () + && regno >= tdep->tls_regnum_base + && regno < tdep->tls_regnum_base + tdep->tls_register_count) fetch_tlsregs_from_thread (regcache); } @@ -592,6 +593,7 @@ aarch64_store_registers (struct regcache *regcache, int regno) aarch64_gdbarch_tdep *tdep = gdbarch_tdep (regcache->arch ()); + /* Do we need to store all registers? */ if (regno == -1) { store_gregs_to_thread (regcache); @@ -606,22 +608,26 @@ aarch64_store_registers (struct regcache *regcache, int regno) if (tdep->has_tls ()) store_tlsregs_to_thread (regcache); } + /* General purpose register? */ else if (regno < AARCH64_V0_REGNUM) store_gregs_to_thread (regcache); - else if (tdep->has_sve ()) + /* SVE register? */ + else if (tdep->has_sve () && regno <= AARCH64_SVE_VG_REGNUM) store_sveregs_to_thread (regcache); - else + /* FPSIMD register? */ + else if (regno <= AARCH64_FPCR_REGNUM) store_fpregs_to_thread (regcache); - - /* Store MTE registers. */ - if (tdep->has_mte () - && (regno == tdep->mte_reg_base)) + /* MTE register? */ + else if (tdep->has_mte () + && (regno == tdep->mte_reg_base)) store_mteregs_to_thread (regcache); - - if (tdep->has_tls () - && regno >= tdep->tls_regnum_base - && regno < tdep->tls_regnum_base + tdep->tls_register_count) + /* TLS register? */ + else if (tdep->has_tls () + && regno >= tdep->tls_regnum_base + && regno < tdep->tls_regnum_base + tdep->tls_register_count) store_tlsregs_to_thread (regcache); + + /* PAuth registers are read-only. */ } /* A version of the "store_registers" target_ops method used when running -- 2.25.1