From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 119F73858D32 for ; Fri, 25 Aug 2023 21:16:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 119F73858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from csb.redhat.com (deer0x03.wildebeest.org [172.31.17.133]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 122BF302BBEC; Fri, 25 Aug 2023 23:16:56 +0200 (CEST) Received: by csb.redhat.com (Postfix, from userid 10916) id E6F5CE1B53; Fri, 25 Aug 2023 23:16:55 +0200 (CEST) From: Mark Wielaard To: gdb-patches@sourceware.org Cc: Keith Seitz , Mark Wielaard Subject: [PATCH] Fix gdb/coffread.c build on 32bit architectures Date: Fri, 25 Aug 2023 23:16:53 +0200 Message-Id: <20230825211653.2097671-1-mark@klomp.org> X-Mailer: git-send-email 2.39.3 In-Reply-To: <3b0896a6-04d4-4c7c-ac32-9ae78acdb66c@redhat.com/> References: <3b0896a6-04d4-4c7c-ac32-9ae78acdb66c@redhat.com/> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3035.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: The getsymname function tries to emit an error using %ld for an uintptr_t argument. Use PRIxPTR instead. Which works on any architecture for uintptr_t. --- gdb/coffread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/coffread.c b/gdb/coffread.c index ae7632d49cb..c609c963453 100644 --- a/gdb/coffread.c +++ b/gdb/coffread.c @@ -1325,7 +1325,7 @@ getsymname (struct internal_syment *symbol_entry) if (symbol_entry->_n._n_n._n_zeroes == 0) { if (symbol_entry->_n._n_n._n_offset > stringtab_length) - error (_("COFF Error: string table offset (%ld) outside string table (length %ld)"), + error (_("COFF Error: string table offset (%" PRIxPTR ") outside string table (length %ld)"), symbol_entry->_n._n_n._n_offset, stringtab_length); result = stringtab + symbol_entry->_n._n_n._n_offset; } -- 2.39.3