From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [pushed] Use sect_offset_str in cooked_index::dump
Date: Mon, 28 Aug 2023 10:36:42 -0600 [thread overview]
Message-ID: <20230828163642.3544637-1-tromey@adacore.com> (raw)
Mark Wielaard pointed out that cooked_index::dump uses PRIx64, and
Andreas Schwab pointed out that gdb already has sect_offset_str. This
patch applies both these observations.
---
gdb/dwarf2/cooked-index.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gdb/dwarf2/cooked-index.c b/gdb/dwarf2/cooked-index.c
index 351f0016402..d6531260c86 100644
--- a/gdb/dwarf2/cooked-index.c
+++ b/gdb/dwarf2/cooked-index.c
@@ -584,8 +584,7 @@ cooked_index::dump (gdbarch *arch) const
gdb_printf (" qualified: %s\n", entry->full_name (&temp_storage, false));
gdb_printf (" DWARF tag: %s\n", dwarf_tag_name (entry->tag));
gdb_printf (" flags: %s\n", to_string (entry->flags).c_str ());
- gdb_printf (" DIE offset: 0x%" PRIx64 "\n",
- to_underlying (entry->die_offset));
+ gdb_printf (" DIE offset: %s\n", sect_offset_str (entry->die_offset));
if (entry->parent_entry != nullptr)
gdb_printf (" parent: ((cooked_index_entry *) %p) [%s]\n",
--
2.40.1
reply other threads:[~2023-08-28 16:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230828163642.3544637-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).