From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 24F003858D20 for ; Tue, 29 Aug 2023 15:34:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 24F003858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-34ba9d6f033so15501495ab.2 for ; Tue, 29 Aug 2023 08:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1693323284; x=1693928084; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=R82PxMf2oBEJEXTxqUwv+R6urCu+2x4RWjrDnp8wpfo=; b=HiSr55OG9YFqPSV1lwFhZj5oOdJ/ydzqL1cibvB72mAWSCxMZk7wlUmYiBmX606R1q 8tre9Kww0jOzQlBMyAEEy/hldmCBxpn5wFH9xAQgfYv9ImwMtXBScB03+zDzHhzpDyeS 43EuNlNIjNA2+odjNjKTj03OFtEhUKCHEyjn1t/WVEEJ8eAalpVh39HHiEWMKoEz6Ei7 LeZDGY26M0/MQgs+b0cjXlB8TfiFfGWSh3BI4rRhka9dn7MlxmEZA6CZaVoFTlIR3tke m+DGnGRvTfn4SX5dDLKVBz7pHdeVtRL4bDj0dao/nf3+a+OIXWKD+ued49bGSsDR60ra /Ebw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693323284; x=1693928084; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R82PxMf2oBEJEXTxqUwv+R6urCu+2x4RWjrDnp8wpfo=; b=SF2Wtkh/+nDpJJgqQAGCK7l+ESkJFogva6AUFoJCytDyjOUQSWSTpXFyrHEWrYmJTX mBGXNGkVRikkSXpZCgG3EWfXd+cc/jKIYXvkTrkK0dHlh1nK7TyDHg/9nYXSlnMVvUOP PCbITu8KTf4HgOcU6BxuhV1ZW3u/bp3szMNZoJswKHc8D1/KeHfohXN2jZDJnNgKK9NE 7vlE1dE6YS8nTimr4nVtVIPVjM2IJsqaiFWqqqxc2CPg1CgktR1qZLYgjWOEP4Ak0EHi MSBKC5LAhFqcUwQlOQtsiw0L+B7Vs/g9GQW885L/PXOd8uRya4nlTMoi/UoBL/b+NX4u 2XnQ== X-Gm-Message-State: AOJu0YyEVSkAQadHZ2/Nr/mdHGqaRjsi1V+vi8QYPcIeoa19puYbmVHY LEUQKpyj/276MWUfXnUGxin9Bg== X-Google-Smtp-Source: AGHT+IGISidzPLNAL7v8RkCjI9+aZ6lD3xJPN+zy3Uc7BdKpSPpO9xoZSL8IWS3n9a0eoGdOKBfgyw== X-Received: by 2002:a05:6e02:1e04:b0:348:d325:2788 with SMTP id g4-20020a056e021e0400b00348d3252788mr22280851ila.32.1693323284478; Tue, 29 Aug 2023 08:34:44 -0700 (PDT) Received: from localhost.localdomain (75-166-150-212.hlrn.qwest.net. [75.166.150.212]) by smtp.gmail.com with ESMTPSA id i6-20020a92c946000000b0034cac5ced38sm3177387ilq.13.2023.08.29.08.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 08:34:44 -0700 (PDT) From: Tom Tromey Subject: [PATCH v2 0/7] Small cleanups in array_operation::evaluate Date: Tue, 29 Aug 2023 09:34:38 -0600 Message-Id: <20230829-cleanup-array-op-v2-0-3035458b0443@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAA4Q7mQC/32NTQqDMBBGr1Jm3Sn5EdSueo/iYoxjDdREJlYq4 t0bPUCXD973vg0Si+cE98sGwotPPoYM5noBN1B4MfouMxhlrKpMhe7NFD4TkgitGCcsarbU27Y rCwt5Ngn3/nsmn03mlhJjKxTccIRGSjPLIQ4+zVHW83rRh/7nZdGoUBtHSvVG1bp8UEcuCt9cH KHZ9/0HxRhoNcsAAAA= To: gdb-patches@sourceware.org Cc: John Baldwin X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: While working on another, larger, series, I found a few small cleanups to do in array_operation::evaluate. I've made each one a separate patch to try to keep each one reasonably obvious. Regression tested on x86-64 Fedora 36. --- Changes in v2: - Added two more cleanup patches - Link to v1: https://inbox.sourceware.org/gdb-patches/20230828-cleanup-array-op-v1-0-12ca00f20917@adacore.com --- Tom Tromey (7): Use gdb::array_view for value_array Declare 'tem' in loop header in array_operation::evaluate Hoist array bounds check in array_operation::evaluate Remove redundant variable from array_operation::evaluate Remove another redundant variable from array_operation::evaluate Remove "highbound" parameter from value_array More renames in array_operation::evaluate gdb/eval.c | 34 +++++++++++++--------------------- gdb/rust-lang.c | 2 +- gdb/valops.c | 21 ++++++++------------- gdb/value.h | 4 ++-- 4 files changed, 24 insertions(+), 37 deletions(-) --- base-commit: aa7b36b832a1475fad2f184e0b4b58fb2f12241f change-id: 20230828-cleanup-array-op-49e3af3bd743 Best regards, -- Tom Tromey