From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id ACCD53858C2A for ; Wed, 30 Aug 2023 19:13:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACCD53858C2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 662E81F45F for ; Wed, 30 Aug 2023 19:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1693422786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QW/TSb/Go9+idngCfOGKsEM0j2iVJF+5Et9L1ve6WiU=; b=Z1EnMvnR0/+l8Rd11CymJ9mCsWvZEACaCZ4XS300iRy1GCh0ssHRlIU830VzUJexKnaHXz sLQqV/vkUSJ8k3xY4VJtu5AdveVxsrzcMv/6xY/lWTNkHmUyyBv9GwcBH3+B89yPsawVQ4 kPyNGwg9rEn9mIjPYacH8PEZbdApqb4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1693422786; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QW/TSb/Go9+idngCfOGKsEM0j2iVJF+5Et9L1ve6WiU=; b=Kyhj01f3MwbrZi06c7ipbP/LVJO++9KNblZKtWLsCAUBezJAg1SXM1RAyr0JeMEKTPJ+9x k/5Pt91C3ii5GlCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 47EA61353E for ; Wed, 30 Aug 2023 19:13:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hQxdEMKU72Q2IQAAMHmgww (envelope-from ) for ; Wed, 30 Aug 2023 19:13:06 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH 1/6] [gdb/symtab] Fix uninitialized memory in buildsym_compunit::finish_block_internal Date: Wed, 30 Aug 2023 21:13:31 +0200 Message-Id: <20230830191336.15885-1-tdevries@suse.de> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: When running test-case gdb.dwarf2/per-bfd-sharing.exp with target board stabs, gdb either segfaults or asserts due to reading uninitialized memory, allocated here in buildsym_compunit::finish_block_internal: ... ftype->set_fields ((struct field *) TYPE_ALLOC (ftype, nparams * sizeof (struct field))); ... Fix this by using TYPE_ZALLOC instead. Tested on x86_64-linux. PR symtab/30810 Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30810 --- gdb/buildsym.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/buildsym.c b/gdb/buildsym.c index 832b689cf03..65ce3a0f5a8 100644 --- a/gdb/buildsym.c +++ b/gdb/buildsym.c @@ -267,7 +267,7 @@ buildsym_compunit::finish_block_internal ftype->set_num_fields (nparams); ftype->set_fields ((struct field *) - TYPE_ALLOC (ftype, nparams * sizeof (struct field))); + TYPE_ZALLOC (ftype, nparams * sizeof (struct field))); iparams = 0; /* Here we want to directly access the dictionary, because base-commit: 59487af3c8490bc5961d330bc0ef4d5f05ecdc59 -- 2.35.3