From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by sourceware.org (Postfix) with ESMTPS id BDF173858C2D for ; Fri, 1 Sep 2023 14:47:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BDF173858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-79277cfc73bso72161839f.1 for ; Fri, 01 Sep 2023 07:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1693579634; x=1694184434; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J20rkiRN3eiqQrIEi1ivxh+az7ctlnuTYxXjQCR+HrY=; b=D85iRZIuXk+Mx9fXFNe98zm+fJoGXZ6anckFBJXeNHUrVeILqQb51xADsF0ttBGNkk 3/XRkXRROPJ5kywNYJgek9XKcU8S1P+k1oMJ+wmaFDqZGWlwBBa5/yxLP0HG5xeN8eiH F913YkJ2gmPUGrFYm89UEH0RaCqqFj0n4WUhdiKzoi+dCWr6WwmRWIvT/bA/HkwmUu2U w0GNQckUeu/aXuWacO+tJy7cuwx7F8r6rJksqMaqJS8Inpl+wmIUaTH1KDlkcFFrvp/E fTA4aVKcYw47gFAP4V02S9KOjEf9Cy2Z1wq8PKQuegWjrQ9liNzHASCER/9/YVSMTm/r OZ0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693579634; x=1694184434; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J20rkiRN3eiqQrIEi1ivxh+az7ctlnuTYxXjQCR+HrY=; b=P19r/vx+6gXUSaKNab95ubNAKvydF1oG9X/4cVALG04XrspiO43cy9LdqQKAENdBXS xg3wtOdZ5pbX/ZZCKDR363x/yXeathgLR7J77XW5RskXeYyDcqMXAPKbqhJrPMBgDIi8 tb8nmuQj+4pZ4B7hnic+uLX2kFg0p4xe8aimtLH1Ywt6Y5GiiVjBs1vhEFUl/yHdcKz4 bDvLm86Q+Pn7p8DrtJdGINdA3h3vl1GEsbW2RotA+eXZpn1Snpvvvz4RTiiPumSMhpLy lksMZ/CI3Z+CwA1ndT5bMyuSkwBO6Gsj9nb8t5hQis01zLBzNnYTEGQ2HfFb1lLjA778 I0Vw== X-Gm-Message-State: AOJu0YwtRfeyj+YvTujRtK8Y9E4Z/jksr+7AnbHtV+b+GRra/s/jGoHb Nl2OvTaAjfXAlLiMxaNHUZdfjPy3khBo9B21OSYD0w== X-Google-Smtp-Source: AGHT+IG5IhkRXV8S8u2jfzGawJTu5vug0TnDcz1/6Qn7NjkC13d8xtxs64et5YCQ2O5L+YYLBG6Img== X-Received: by 2002:a05:6602:3b88:b0:786:25a3:ef30 with SMTP id dm8-20020a0566023b8800b0078625a3ef30mr2801520iob.7.1693579633998; Fri, 01 Sep 2023 07:47:13 -0700 (PDT) Received: from localhost.localdomain (75-166-150-212.hlrn.qwest.net. [75.166.150.212]) by smtp.gmail.com with ESMTPSA id q1-20020a0566380ec100b0042b1a9f8480sm1036710jas.35.2023.09.01.07.47.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 07:47:13 -0700 (PDT) From: Tom Tromey Date: Fri, 01 Sep 2023 08:47:12 -0600 Subject: [PATCH 2/4] Remove dead code from varobj_set_display_format MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230901-varobj-fixes-v1-2-b9a1f8139ca7@adacore.com> References: <20230901-varobj-fixes-v1-0-b9a1f8139ca7@adacore.com> In-Reply-To: <20230901-varobj-fixes-v1-0-b9a1f8139ca7@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: varobj_set_display_format takes an enum and exhaustively switches on the values -- but also has a default. This default case is dead code. --- gdb/varobj.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/gdb/varobj.c b/gdb/varobj.c index 52e62aca265..760809c6f51 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -488,20 +488,7 @@ enum varobj_display_formats varobj_set_display_format (struct varobj *var, enum varobj_display_formats format) { - switch (format) - { - case FORMAT_NATURAL: - case FORMAT_BINARY: - case FORMAT_DECIMAL: - case FORMAT_HEXADECIMAL: - case FORMAT_OCTAL: - case FORMAT_ZHEXADECIMAL: - var->format = format; - break; - - default: - var->format = variable_default_display (var); - } + var->format = format; if (varobj_value_is_changeable_p (var) && var->value != nullptr && !var->value->lazy ()) -- 2.40.1