From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by sourceware.org (Postfix) with ESMTPS id 7E56E3858C39 for ; Fri, 1 Sep 2023 14:47:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E56E3858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-79289fefdbeso73649539f.3 for ; Fri, 01 Sep 2023 07:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1693579634; x=1694184434; darn=sourceware.org; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=XqiNB8w6HRY5WdZkPbH5F/rm9RvcxCwwzLCA8b5ycUA=; b=Gsl3cLxHVSKl48AHx+pHyiR2Fsbx6DywkOWUjJN2yKk1IhP35uWL4QlZxYTzRMi6f2 gXvUM7PtZX+agkiJKM37g4apzeFJGXwp4ED9CykMfyFp0BAQaIYXKAPiwCfzNqT1KHzW RBioJQgvUb+SMkJ2OmfRQvGP+fRIBnya43F4mN88wqkAwtdyU47o6Rit+VYC4E2BEl5o jktjzt3KRLMVpeCXkS0AXfeU3qHsAWTF0A75jg3zsG/a1Woy2FVat3k2MxhLHq2A4zFG 12ME80fztWM78UM/4vYepu7ZY+nLUcztEpW4u1cFeg3agW+k6OQnZP+FSYZZgrRbPYTO g8zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693579634; x=1694184434; h=to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XqiNB8w6HRY5WdZkPbH5F/rm9RvcxCwwzLCA8b5ycUA=; b=JcZxhItMHLQu4j1/DKB36JBHNIj1CoA75zMy28hMfJoNGEZ+05NSHrXh8gN9MZTkqM Qybzpv6eOghfWpUvrWDwRO5jzXbUJX552nnneGHXDyESaHMY0r61iw8ZuLsx8yqAACSr 3D47GELGgIsRKwZWgV/8+kMB5qklzKvgZTCHv3n+v0n51jKnkWM/8kB+VJyNcIQpBL+I 3yu1fs0vSnRFgSKwdnhPEplB0INM0UnT7bMycm0kRpRs2a/qO/e9yWY0RP5PMW1Vks6D o8iNzTDw66Cizlcwecc2T7u1gRv3IGe6FE2JmWGgylPv69ixvnTlSqb0SjgYzPURJRNk lmxw== X-Gm-Message-State: AOJu0YxsdAJqTUImb/hRc32ncSkwnGjvBfDJqbC/UQJ2vU0GtQY6PhO1 NkRgR+6SzqGRcA2LIrp+kpZj+o+K8t5g/L+9lnefKA== X-Google-Smtp-Source: AGHT+IGFcKZaQrcbQnZWJCY8dAyBO8tO4aWOJdRIQdNLlRS2AjUmargflaBGpB5xR9EHGRC/OReuWA== X-Received: by 2002:a5e:8804:0:b0:787:8cf:fe8a with SMTP id l4-20020a5e8804000000b0078708cffe8amr2608427ioj.2.1693579634764; Fri, 01 Sep 2023 07:47:14 -0700 (PDT) Received: from localhost.localdomain (75-166-150-212.hlrn.qwest.net. [75.166.150.212]) by smtp.gmail.com with ESMTPSA id q1-20020a0566380ec100b0042b1a9f8480sm1036710jas.35.2023.09.01.07.47.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Sep 2023 07:47:14 -0700 (PDT) From: Tom Tromey Date: Fri, 01 Sep 2023 08:47:13 -0600 Subject: [PATCH 3/4] Remove variable_default_display MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230901-varobj-fixes-v1-3-b9a1f8139ca7@adacore.com> References: <20230901-varobj-fixes-v1-0-b9a1f8139ca7@adacore.com> In-Reply-To: <20230901-varobj-fixes-v1-0-b9a1f8139ca7@adacore.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.3 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: variable_default_display has a single caller now, so remove it. --- gdb/varobj.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/gdb/varobj.c b/gdb/varobj.c index 760809c6f51..3ae8d728e82 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -164,8 +164,6 @@ create_child_with_value (struct varobj *parent, int index, /* Utility routines */ -static enum varobj_display_formats variable_default_display (struct varobj *); - static bool update_type_if_necessary (struct varobj *var, struct value *new_value); @@ -336,7 +334,7 @@ varobj_create (const char *objname, return NULL; } - var->format = variable_default_display (var.get ()); + var->format = FORMAT_NATURAL; var->root->valid_block = var->root->floating ? NULL : tracker.block (); var->root->global @@ -1871,14 +1869,6 @@ varobj_get_value_type (const struct varobj *var) return type; } -/* What is the default display for this variable? We assume that - everything is "natural". Any exceptions? */ -static enum varobj_display_formats -variable_default_display (struct varobj *var) -{ - return FORMAT_NATURAL; -} - /* * Language-dependencies */ -- 2.40.1