From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by sourceware.org (Postfix) with ESMTPS id 8CDA43858D35 for ; Mon, 4 Sep 2023 22:30:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CDA43858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693866614; x=1725402614; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OhPeDO4BQIMIfj+MyKP07HBwqsZY9NADSXoUZ4uVToU=; b=OCYDIIEQCVlMvTtTfzWNeXlw4WZIkjpZsaQG5flt9QFhkI1BPtl1Rcrc LXAI9bmnBPxsQv46yR/MvCM7sSWdXfztnBj4KrEnN1xvGi6fIi82btr7M HH6DWOHTB1Dsd/ISjHE4qMXZMvU+CMkX/fwQ/rhRawZ00DszV3/mjjrc6 KPDlFvxZJj8okCN4UcHcPN+jgXBexPdxSwhuKbWSMMrHkzNSTjlwrUdKj iDmOpNIA+aH0EfEwakNOqLC3Y34H+jQqHuE0WWOy9FywXIJW27m2IcDhW rihfiPJOfRUPbDa8iGnGY0TMDWUFJO53NSq5h8HlMd0wlplsX03F2snd0 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="356973315" X-IronPort-AV: E=Sophos;i="6.02,227,1688454000"; d="scan'208";a="356973315" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 15:30:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10823"; a="884109242" X-IronPort-AV: E=Sophos;i="6.02,227,1688454000"; d="scan'208";a="884109242" Received: from abijaz-mobl2.ger.corp.intel.com (HELO localhost) ([10.252.60.194]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2023 15:30:04 -0700 From: Abdul Basit Ijaz To: gdb-patches@sourceware.org Cc: abdul.b.ijaz@intel.com, simark@simark.ca, tom@tromey.com Subject: [PATCH v3 0/4] Dynamic properties of pointers Date: Tue, 5 Sep 2023 00:29:52 +0200 Message-Id: <20230904222956.15203-1-abdul.b.ijaz@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: "Ijaz, Abdul B" Hi! Please find attached v3 of this series where for v2 series there is already some feedback and the main change in patch 3 review is still missing to fix 'some compiler DWARF that is wrong but we still want to support it' patch after a discussion in https://sourceware.org/pipermail/gdb-patches/2022-September/192159.html V2 patch 2 was approved by Tom already in this discussion but there are minor changes since then: https://sourceware.org/pipermail/gdb-patches/2023-January/195353.html V2 can be found here: https://sourceware.org/pipermail/gdb-patches/2022-October/192389.html V1 with feedback can be found here: https://sourceware.org/pipermail/gdb-patches/2022-September/191934.html Changes since v2: * Patch 1 has minor change where now test for icc versions more generally. * Patch 2: Patch 2 has minor change in TYPE_CODE_PTR handling and rest was already reviewed in V2 series for handling of DW_AT_associated attribute in patch 3. * Patch 3: This already has the DW_AT_associated handling from V2 series and only handling of reference/pointer type is improved for Intel classic compilers. * Patch 4: Added a comment to the change for handling of DW_TAG_pointer_type. I'm looking forward to comments. Thanks & Best Regards, Abdul Basit Bernhard Heckel (1): gdb, types: Resolve pointer types dynamically Nils-Christian Kempke (3): gdb, testsuite: handle icc and icpc deprecated remarks gdb, intel-classic-compilers, testsuite: workaround icc/icpc/ifort pointer/reference DWARF gdb, testsuite, fortran: Fix sizeof intrinsic for ifort Fortran pointers gdb/eval.c | 9 + gdb/gdbtypes.c | 101 +++++++++- gdb/gdbtypes.h | 5 + gdb/testsuite/gdb.cp/vla-cxx.cc | 4 + gdb/testsuite/gdb.cp/vla-cxx.exp | 15 ++ gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp | 16 +- .../icc-ifort-pointers-and-references.c | 38 ++++ .../icc-ifort-pointers-and-references.exp | 169 +++++++++++++++++ .../gdb.fortran/pointer-to-pointer.exp | 2 +- gdb/testsuite/gdb.fortran/pointers.exp | 173 ++++++++++++++++++ gdb/testsuite/gdb.fortran/pointers.f90 | 29 +++ gdb/testsuite/gdb.fortran/sizeof.exp | 115 ++++++++++++ gdb/testsuite/gdb.fortran/sizeof.f90 | 108 +++++++++++ gdb/testsuite/lib/gdb.exp | 14 +- gdb/valprint.c | 40 +++- 15 files changed, 812 insertions(+), 26 deletions(-) create mode 100644 gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.c create mode 100644 gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.exp create mode 100644 gdb/testsuite/gdb.fortran/pointers.exp create mode 100644 gdb/testsuite/gdb.fortran/sizeof.exp create mode 100644 gdb/testsuite/gdb.fortran/sizeof.f90 -- 2.34.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928